Looks like the build is successful for tfx with no failing tests yay 🎉

I'll run some tests with them later with the apps I have on my computer 🙂

Thanks Amanda 🙂 Merged!

How do I conditionally set a textfield to be required - is there something similar to

requiredWhen

?

@gtnarg No, you'd have to turn it on and off. But we could add it probably quite easy. A bit uncommon use case though, what do you need it for? I ask because I'm curious, I've never run into that before

Untitled.kt

The

condition

parameter could also be an observable value of course, if that makes describing the condition easier

-.kt

Ah, we don't have a module-info file yet 🙂

Enumerating requires modules and will commit a module-info.java soon. Will also update versions to J11 etc

I must admit there is a lot I don't know about the module system yet. Will do some more reading, but I committed a preliminary module-info.java.

As far as I remember it's not necessary to declare your own modules, nameless modules are automatically packed to ubermodule by default or something like that, so that's how they achieve backward comparability. Are you trying to modularize TornadoFX?

@carlw et al, any thoughts on what would cause this issue? https://github.com/ReactiveX/RxJavaFX/issues/76

checking

i'll have to look at this later. getting this error in java 11 Error occurred during initialization of boot layer java.lang.LayerInstantiationException: Package jdk.internal.jrtfs in both module java.base and module jrt.fs

I put the contents of the gluon openjfx into the zulu open JDK folders but there seems to be a conflict

@carlw try building off the branch?

It's been updated for Java 11. No artifacts for Java 11 yet

seems to be an intellij thing

@alex Modularization is not the primary goal no, just trying to be a first class citizen in the module world 🙂 A module is created anyway, might as well have control over it - that was my thinking, but I don't know much about the module system yet.

i think we have to go the extra mile and make javafx modularized even if ther eis only one. from my reading, chucking everything on the classpath is just for legacy considerations. i'm still coming up to speed on 11

how many times can i "throw IllegalArgumentException" without the new today?

Woah, I missed a lot on this channel. I can only spend so much time in the week :-(. Since, I’m still new I have some (possibly naive) questions about the idea of migrating TornadoFX to Java11: Regarding modules: have you guys run jdeps to see what dependencies that may need to be updated? Is the latest version of Kotlin able to run on Oracle’s Java 11? Have you moved the project to Java 9 or 10 yet? From what I hear from others moving from 8 to 11 might be too big of a jump if you’ve not moved to Java 9 yet. If it already runs on Java 9 or 10, are you using the unnamed module (legacy classpath files)? If none of your code is using Java11 language features like ‘var’ you can compile source 11 target 11, 10 or 9. Hopefully that helps.🧐

👍

@edvin i think there's a new feature in JAR files that lets you keep version specific code in a separate folder. is that feasible for the project or are there too many core reliances on com.sun (now public) classes?

@carlw That's not a feasible solution for us. Since we'll be compiling to J11 byte code, that would mean double size to maintain J8 byte code as well, so there are many show stoppers for that approach. It would also be harder to maintain.

ok. sounds like a cool feature. maybe for the future if a new v12 component comes on line in javafx that's not found in v11?

@carlw Yeah, maybe for something like that, but remember that new non-LTS releases are EOL after 6 months. There probably won't be any good reasons to continue support after EOL. With releases every 6 months we can't keep track of backports for all those EOL'ed releases 🙂

I think most features we'll depend on will be from JavaFX, not from the JDK itself. Language features we'll get from Kotlin.

i was thinking about whole new components like when Alert was added for 8u40 (and not found in 8u25). you could make the new component available in this jar mechanism with some tornadofx code. if you have the right jdk, you can use it