Channels
#tornadofx
- e
edvin
07/29/2016, 6:07 PMI think I need to detect if I'm in an OSGi bundle and encode the bundle id in the url somehow. - r
Ruckus
07/29/2016, 6:08 PMI don't know much about OSGi still, but isn't that what the Activator does? - e
edvin
07/29/2016, 6:11 PMNo, the Activator is just a bundle initializer. - e
edvin
07/29/2016, 6:11 PMI have a plan now 🙂 - e
edvin
07/29/2016, 6:13 PMI'm trying to encode the bundle id in the query part of the url and then resolve the class from that bundle in the url handler. - e
edvin
07/29/2016, 6:13 PMThe handler will resolve the class like this: - r
Ruckus
07/29/2016, 6:21 PMI can more or less understand what is going on 🙂 - r
Ruckus
07/29/2016, 6:21 PMWill
crash if it's not coming from OSGi?val owningBundle = bundleContext.getBundle(url.query.toLong())!! - e
edvin
07/29/2016, 6:22 PMYes, but this code is in the OSGi specific part of the framework. A class that is only instantiated if the OSGi runtime requests it. - e
edvin
07/29/2016, 6:22 PM(I forgot to mention, this is a separate implementation of the CSSURLHandler) - e
edvin
07/29/2016, 6:22 PMThen I'm thinking we need to augment the importStylesheet function so that it encodes the bundleId - r
Ruckus
07/29/2016, 6:23 PMOkay, that makes sense. - e
edvin
07/29/2016, 6:23 PMThe
function is defined like this (not tested yet):FX.getBundleId - e
edvin
07/29/2016, 6:23 PMDon't know if this will work yet 🙂 hehe - e
edvin
07/29/2016, 6:24 PMI could cache the result of the framework detection to speed things up for subsequent calls, but I don't know if the gain would even be measurable. - r
Ruckus
07/29/2016, 6:26 PMWhy do you need
? Doesn't it have to exist forClass.forName("org.osgi.framework.FrameworkUtil")
to compile?FrameworkUtil.getBundle(...) - e
edvin
07/29/2016, 6:26 PMNo, that's the beauty 🙂 - e
edvin
07/29/2016, 6:26 PMThis compiles, because the OSGi API is on the compile path. - e
edvin
07/29/2016, 6:26 PMBut not necessarily on the runtime path. - r
Ruckus
07/29/2016, 6:27 PMOh, I see - r
Ruckus
07/29/2016, 6:27 PMThat is cool 🙂 - e
edvin
07/29/2016, 6:28 PMHopefully 🙂 - e
edvin
07/29/2016, 6:39 PMThat eerie feeling when everything works on the first try.. 🎉🎉 2 - r
Ruckus
07/29/2016, 6:50 PMOne of the worst best feelings in the world - e
edvin
07/29/2016, 8:05 PMI can live with it 🙂