Okay, haha that is true. But ControlsFX moves a bit faster. I think that is the part I'm trying to figure out.

yes, so the best approach is to iterate quickly in your kotlin repos / controlsfx, and then once you are happy it can start the process of moving into openjfx, if it is accepted as an enhancement

That's kind of what I'm thinking. Definitely getting our stuff in openjfx is a win for us and everyone else.

yes, it is a nice feeling having your code on millions of machines 🙂

Haha that's why we open-source and give away cool stuff for free, right? We hope it helps others, and if it becomes a global standard then that's the highest achievement!

yep

Alright, it's getting late here. Hitting Netflix then crashing. Glad your here @jonathan ! Enjoy the rest of your day.

later

Hi @thomasnield , sorry wasn't online anymore when you wrote welcome. It was 2am in Germany and I was too tired 🙂

Thomas is in the states TZ so he probably sleeping 🙂

but welcome from me too

11.00 here in the netherlands

Hi Ron, same in germany 🙂

So you decided to join the kotlin side?

Hi Gerrit 🙂

About the RowExpander feature.. It should be quite easy to rewrite that in plain Java and make it fit with ControlsFX. For OpenJFX the integration could be even smoother of course. It could be done with some small additions in the TableRowSkin actually. I will try to make it a standalone plain Java feature first.

No worries @frosch95, we all work on an international clock here 🙂

how much is this going to slow down the tornadofx development? if features are being ported to javafx?

@ron like @jonathan said OpenJFX moves very slowly, so I don't think it will have that much of an impact there. ControlsFX may slow things down slightly when stuff is strategically put there, but it would make sense to leverage that since most of us use ControlsFX already.

Well, I will help where I can

porting from kotlin to javafx I can do 😉

thinking up the weird features too 😉

haha awesome, I think @edvin will need help there. The last ControlsFX feature I made was TableFilter, and I already started to put a wrapper around it in TornadoFX-ControlsFX

but I think most of us have seen awesome projects die when "commitees and communities get involved"

For now we're talking about pretty minor contributions. Rewriting the initial version of the RowExpander will take less than an hour. Contributing to the framework we are based upon also seems like a pretty good idea to me 🙂 I think TornadoFX is where we will continue to innovate, but if we can create some features that make it back into OpenJFX or ControlsFX that is a huge benefit for everyone - and with little to no cost for us.

I can live with that

like I said I am always a bit weary when things like this happen

I was looking btw at the focusmodel(seeing if I could hack keyboard translation into datagrid)

but I feel I am missing some information, was actually reading the listview implementation in the openjfx repo to see how it works and what is needed, but I miss the link between the keys and the code