I converted it to JavaFX with no dependencies in about half an hour 🙂 Committed to TornadoFX-Controls for now. I need to look at the structure of ControlsFX and adjust my code to match that.

You might put the public exposed API here.

And your internal implementation classes here

That's where I've put the TableFilter control and @jonathan suggested those locations. the

impl

folder in the

src

is where "internal" stuff goes.

Are there any good resources out there for writing javafx components (i.e., skins, behaviors etc)?

@jonathan one thing that would help the

TableView

also is exposing more properties indicating where different

TableView

components are located on the screen. For instance with the

TableFilter

in ControlsFX, I had to get super hacky and needed assistance from SO just to place a

ContextMenu

under a

Column

header. It would be helpful to have "Corner" and/or "Dimenision" properties that can be bound to.

I guess being able to anchor floating controls under column headers and cells is what I'm looking for

@gtnarg how low level are you talking? Are you looking to make new controls out of the existing controls? Or building from scratch?

Great. I'm not sure what would be the best public api for the expander. Right now it looks like this:

@User uploaded a file: Untitled

(And I guess I should have used something else than a Form for the example)

I guess that works. I was thinking a static utility class but that's more object-oriented

I can add a static member to TableRowExpander. Something like

TableRowExpander.install(...)

perhaps.

I was throwing around a TableViewUtils static utility class idea earlier that would hold several helper functions. But I guess it would be helpful to have full access to the object to manipulate its properties

I think your Constructor approach is probably best

Actually,

install

makes it nicer, since you can get rid of the diamond operator there. Looks cleaner. I'm updating the example above.

As long as it returns an object to control the row expand functionality

And possibly even remove it

I don't like that there are two parameters to the builder function. Either it should just take a customer, or it should take an object ala

TableColumn.CellDataFeatures

.

Using

javafx.util.Callback

is probably more conforming to both JavaFX and ControlsFX.

@thomasnield out of existing controls (like you did with controlsfx ListSelectionView)

Updated the syntax above again 🙂

@gtnarg Oh you are referring to the TableFilter. I don't know if I have the best answer since I can't think of any specific resources. Like most things I take a hacker approach. I have a specific (not broad) objective and I may have little idea how to do it. But I keep a narrow focus on what I am trying to accomplish and research all the pieces I need just for that problem. That's what I did with the TableFilter. I threw together a VBox and put all the different controls inside of it. And I gave it access to the outside pieces it needed (e.g. the TableView itself). Then I researched and hacked my way to make that VBox pop up under a column header, and that was one of the few times I copied something verbatim from StackOverflow.

Generally, be good at not just JavaFX but applying and integrating it. Know how to make different JavaFX controls talk to each other through well-planned event handlers (I really prefer Rx for that stuff but obviously that won't fly if I put it in ControlsFX). I really wish I had a better answer so I hope that helps.

@edvin I like it, and agreed on the Callback

@thomasnield ok - thanks - was just curious as the topic never seems to be covered anywhere...

@gtnarg: it should be covered more at least by documenting design patterns. Code samples are the best way to learn most things imo, and many problems require a case by case mindset rather than seeking a standardized discipline.