If I do come across any resources I'll forward them your way

@thomasnield thanks - appreciated 🙂

I've committed the change to use a

TableRowDataFeatures

class for the Java version: https://github.com/edvin/tornadofx-controls/blob/master/src/main/java/tornadofx/control/TableRowExpander.java

It seems to create the content node twice the first time though, need to investigate later tonight 🙂

This is the expander column: https://github.com/edvin/tornadofx-controls/blob/master/src/main/java/tornadofx/control/ExpanderTableColumn.java

And this is the skin: https://github.com/edvin/tornadofx-controls/blob/master/src/main/java/tornadofx/control/skin/ExpandableTableRowSkin.java

Bug squashed. What's more interesting: We had this bug in the TornadoFX version as well, so looking at the control from a slightly different angle (JavaFX/Java8) actually made the TornadoFX component more stable as well. Bonus!

@jonathan Now that we have a plain Java version of the RowExpander with no dependencies I wonder if this is a feature you would consider for ControlsFX? I also wonder if you think the TableRowSkin approach was the right way to go about this. I'm sure you'll have plenty to say about API and naming for sure 🙂 The component consists of three classes, links to the Java code is above, here is a usage example with the current syntax:

@User uploaded a file: Untitled

param

is a

TableRowDataFeatures

object which gives access to

tableRow

,

tableColumn

(the expander column) and

value

along with functions like

toggleExpanded()

,

isExpanded()

,

setExpanded(boolean)

and

expandedProperty()

.

To use a custom node as the toggle node in Java:

@User uploaded a file: Untitled

@gtnarg Jonathan Giles did a talk at devoxx it is a bit older, but maybe a good start. I am not sure if any newer talk exist.

As this talk covers JavaFX 2 the API may have changed.

@frosch95 - thanks I will check it out.

And Gerrit who creates fantastic non standard widgets has another talk

This book is also a great resource: http://www.guigarage.com/javafx-book/

@gtnarg you are welcome.

That talk by Gerrit helped me a lot before I created my first control.

the friday fun components @hansolo_ are great ... http://harmoniccode.blogspot.de/search/label/fridayfun

@edvin I had a quick look on your code and I am not sure if this tip of jonathan isn't also suitable for your ExpanderTableColumn >You shouldn’t create new instances of nodes in the updateItem method - instantiate them once in the cell constructor and reuse

As defaultToggleNodeProvider() always generates a new Button inside the updateItem method

you guys are too active for me - I can’t keep up (especially as I’ve only woken up an hour ago and already see many mentions of my name)

@frosch95 is right

that devoxx talk feels very old now!

the tornadofx people are usually very very active

dont mention an idea to @edvin he will have it done before you finish the sentence

all other comments can probably be handled via ControlsFX pull requests, I would guess

fwiw, I’m giving a custom controls talk at JavaOne in 3 weeks time 🙂

And Gerrit is doing a custom controls hands-on lab