Maybe. The editors are just created on expand, and thrown away after use, but you might be on to something.

I just found a flaw in the skin, I suspect fixing this will resolve the issue.

as to what i use it for

well, yesterday evening my gf was out, so I ended up making myself a PDF viewer app

is a superduper exciting guy

and getting the zoom behaviour right is kind of painful

feels like a reusable problem

although the next thing I add to the viewer is probably going to be sandboxing, as that's more where my interest is at right now

@mikehearn Interesting 🙂 I have never needed zoom before, but I can think of many use cases now. Maybe we can play with making a reusable component for it in a little while.

@frosch95 I have committed a fix for the issue you saw, do you have time to test again? The fix is not the completely correct solution, but it's what I had time for right now. If this works however, I will implement a more solid fix tomorrow.

@frosch95 Bah.. I seem to have introduced another bug though, now the row expander buttons won't always show.

oh that happened to me either, but i could'nt reproduce the error for the screencast

so this might be an "old" bug

Ah, that's good. I couldn't for the life of me figure out how that could have been connected to what I just did 🙂

it works! 🎉

now I need to develop another application to use it ... 😂

@edvin now get some well-deserved 🍰

Haha, I will 🙂 Talk to you later!

Extremely weird. The first expander button has it's update item function called twice, first with -1 and then with index 0, as expected. The other visible cells are only called once, with empty = true, resulting in:

@User uploaded a file:

(don't mind the extra space in the column)

I output some state in the

updateItem

function:

@User uploaded a file: Untitled

Whoa.. actually it was because I had run

setPrefWidth(150)

on the expander column. Wonder what that's all about.

It still happens "once in a while" without, but with the pref width set, it never rendered more than the first expander column correctly.

As far as the zooming feature goes, I have run into need for it in the past. I was making a node based task manager, and trying to implement clean zooming was a pain (not to mention a Pane that can infinitely scroll in either direction; that was a nightmare). However, I'm not sure if it would be a feature that should go in the main TornadoFX library. Perhaps a TornadoFX controls library?

or controlsfx

though then maybe it'd have to be written in java

Indeed

Would it be zooming of a node or a group?