this is the full class

@User uploaded a file: Untitled

Since JavaFX doesn't have

display: none

I think you might be better off by actually removing and adding the node. TornadoFX has a

Node.removeFromParent()

function that makes it a bit easier.

I think the issue with your first example is where you are adding the Label

@frosch95 I made some more internal improvements to the row expander. Hopefully I didn't introduce any new bugs 🙂

(I'll be gone for a few hours)

fold("test", VBox()) { label("test") }

the Label is being added in the scope of the TitlePane, not the VBox. I'm guessing the space left over was exactly the width of the label.

yeah it looks like it

@User uploaded a file: Untitled and commented: this works

You dont need to touch the width if you remove it from the parent :)

@Ruckus @ron I'm glad you guys have been following it. I hope you like it so far, I haven't even gotten to the cool stuff yet.

2157 2133 = 24min = hours ... time is a lot faster in norway 😛

I am waiting for the cool stuff, I understand that pushing event can be interesting, but so far most use cases I have been able to solve with EventBus

I am quite interested in running it different threads

@frosch95: Except when you're "Going to bed now", when time apparently seems to stop completely for some random amount of time.

@edvin expander still works with the new changes

@ron yeah I'm still setting the stage for Rx's benefits. Haven't even gotten started yet. When I cover concurrency, combining Observables, and throttling it will become more useful

@thomasnield Sounds awesome

Haha, yeah, going to bed can be a process. Some times it's quick, other times it takes hours.

In my defense, I was away, I just checked in from my phone 🙂

@frosch95 Great, thanks for checking. I added some javadoc comments to it as well. Will take a final look at it with fresh eyes tomorrow and then maybe bother Jonathan to have a look and see if this is something we could get into ControlsFX.

the threshold for ControlsFX is pretty low

you just need to have something that is generally useful, has a good API, is well documented, and has a sample added into the controlsfx-samples app 🙂

Great @jonathan ! I will review it once more tomorrow and look for caveats. Right now I'm wondering if the skin approach I chose is the best way to go, but I can't really think of a better way to implement this, unless it was done in the actual TableRowSkin in OpenJFX of course. I'm not good with names, so some of the classes might need a better name as well, for example the

ExpanderTableColumn

sounds clunky. It is mostly an internal implementation detail, but still.

@edvin I noticed that when transitioning views, the outgoing view never fires its undocking callback. Is there an easy way to force call it at the end of the transition?

@Ruckus

UIComponent

has

internal fun callOnUndock()

for that purpose, but it might not be needed. I haven't looked at your new implementation yet, but if

UIComponent.muteDocking

is triggered, that would prevent the normal undock call from reaching the UIComponent. Could that be the case? In normal circumstances just changing the parent of the view root would trigger the undock call.

I have to admit not even looking at any of your code, so I have no feedback. But in general, I would wonder whether it could be implemented as a custom rowFactory

Indeed.

muteDocking

is set to

true

at the beginning of the transition and

false

at the end to make sure no strange cleanup code was called before the transition completed.

@jonathan That is what I do. Basically, I just create a default TableRow but I override the

createDefaultSkin

method to return the

ExpandableTableRowSkin

. Would you try to avoid creating a skin altogether? I did this mostly because I have to deal with custom layouts (I implemented

computePrefHeight

and

layoutChildren

in the skin).

I have no issue with a custom skin