in general, when I review my priorities are API (including docs). I don’t normally have issues with impl unless it is clearly stupid

@Ruckus Can you set it to false at some sweet spot to avoid having to call

callOnUndock

manually?

so, my hope would be the API would be something like

tableview.setRowFactory(new RowExpanderFactory())

or similar

@edvin That's what I do to make sure

onDock

is called automatically. I'll mess around with it and see what I can come up with.

I think the undock would normally be called when the component is first but into the temporary

StackPane

though, which is exactly what I'm trying to avoid.

@jonathan I can make that happen, but I also insert a column at position 0 to contain the row toggle button, so either installing the row toggle would have to be two method calls, or the something like the current approach, where both things are done via

TableRowExpander.install(tableView, expandedNodeCallback)

.

@Ruckus I think for this use case it is totally fine to call it manually at the end of the transition 🙂

I see

I don’t mind utility methods in ControlsFX

but it won’t fly in openjfx - but we can cross that bridge later

@edvin Sounds good

Yeah. Possibly in OpenJFX there would be no need to install a custom RowFactory, if the default row factory/skin could know about the toggle functionality directly. If would be a very small change in RowFactory, so then I think the approach would be to just add a toggle column to the columns list to install the functionality.

I will have another look at the implementation, maybe I can make it so that you just add the expander column.

The expander column would then contain the callback to create the expanded node for a row.

Alright,

ViewTransitions

now work for any

Node

with special support for docking of `UIComponent`s

I'll clean up a few things then push it.

@Ruckus Fantastic work!

(Just to my branch, not to master yet)

Can't wait to check it out (tomorrow)

Removing the utility class and embedding the functionality inside the freshly renamed

TableRowExpanderColumn

seems to make a lot of sense. Everything just fits now 🙂

It worked perfectly, and now you can insert the expander column anywhere you want, not just as the first column in the row.

@jonathan I changed it so that you can instantiate the expander column and add it manually to the tableview columns list, but would it be weird to also have a constructor for the column that took the tableview and inserted the column automatically as well?

@User uploaded a file: Default usage

@User uploaded a file: Alternative usage

I.e, is the second alternative here weird or atypical?

That secondary constructor would basically just do:

@User uploaded a file: Untitled

@edvin is this

selectionModel.selectedItemProperty().addListener { e-> println(e) }

the best way to use the selectionModel in the datagrid?

@ron What are you going to do when the selected item changes? If you just want to extract the selected item you can call

selectedItem

directly (a property on the TableView that will extract the

selectionModel.selectedItemProperty().value

no it needs to be a listener that gets called when you click a cell