OK 🙂

@thomasnield I just committed the OSGi chapter to the guide. It is a rewrite of the wiki content with some more explanations offered. I haven't proof read it, just made sure that it includes all pertinent information for now.

@thomasnield The builder parts in the guide.. do they need the "Part X" part in the name? Ie. could

4. Builders Part I - Basic Controls

be renamed

4. Builders - Basic Controls

? To me it looks cleaner, and I don't know if the part number is relevant info. What do you think?

worryingly it was merged and I didn’t even review it! 🙂

I have a build server at my house that publishes snapshots

@jonathan Ouch 🙂 Haha, I'm looking at your comments now. Should I create a new PR when I have all the issues sorted?

It’s ok - I’m actually happy that ControlsFX exists and progresses outside of me

my general plan is to do another controlsFX release in a week or two, before J1

even though I rejected my own ControlsFX submission to JavaOne this year, I still want to get a release out 🙂

Great! I'm looking at your comments now. Learning a lot 🙂

@jonathan: thanks! @edvin we should use that as a dependency for tornadofx-controlsfx

@edvin I think "Part X" does help divide up the builders quite a bit. Kind of helps separate them from non-builder chapters. Welcome suggestions if you or anyone else has thoughts on better naming.

@edvin awesome. I'll review it in the next day or two. Ill focus on getting the chapters finalized so we can put together appendix

Personally, I think starting the chapter with "Builders - " is enough to separate it from the other chapters, or did you want the builders to feel like a separate section in the book?

@thomasnield ^^^

@jonathan I have fixed the issues you mentioned with the exception of the expanded responsibility. Should I submit a new PR?

sure

@jonathan PR submitted. I will try to find of a good way to move the expanded tracking to TableRow. I thought about not having a value factory for the expanded column and just extract the expanded state from the tableRow in updateItem. Would that be a good solution or is it bad to render a control inside a column that has a null value? If so, I could use some static/fake value, but that just feels like a bad hack.

yes, it feels hacky

@Ruckus: I can do that, are you cool with that @edvin ?

Absolutely @thomasnield

@jonathan hey another TableView tweak that might be minor but very helpful http://stackoverflow.com/questions/38176131/javafx-tableview-resetting-the-column-sorts

It isn’t clear to me what you want to do

you want to remove all sorting at a point of your choosing?

or you want to disable sorting at certain points in time?

Remove all sorting at any point of my choosing

Programmatically

When you click on the headers to sort columns, I want to be able to remove all sorts through some method call on

TableView

.

tableView.getSortOrder().clear() should work?