Channels
#tornadofx
- e
edvin
09/03/2016, 6:03 PMSo if we made the change now (remove this and add the new), existing code would actually still compile, but no value would be provided, right? - t
thomasnield
09/03/2016, 6:04 PMHmmm... trying to process all of this - t
thomasnield
09/03/2016, 6:04 PMIf removing that method allows us to turn this: - t
thomasnield
09/03/2016, 6:04 PM@User uploaded a file: Untitled - t
thomasnield
09/03/2016, 6:05 PMInto this: - t
thomasnield
09/03/2016, 6:05 PMI'm a happy camper - t
thomasnield
09/03/2016, 6:05 PMWe want to rid explicit typing requirements, as well as - e
edvin
09/03/2016, 6:06 PMI think we should consider removing it and releasing 1.6.0 instead to signal that we have incompatible changes. - t
thomasnield
09/03/2016, 6:06 PMprovide an
or a non-ObservableValueObservableValue - t
thomasnield
09/03/2016, 6:06 PMOkay - t
thomasnield
09/03/2016, 6:07 PMI know that
may cause messiness, but...apply { } - t
thomasnield
09/03/2016, 6:07 PMdoes this streamline majority of use cases? - e
edvin
09/03/2016, 6:07 PMThis would rid the need for
alltogether.apply - t
thomasnield
09/03/2016, 6:08 PMUnless you want to configure other things about the column - e
edvin
09/03/2016, 6:08 PMYes, so absolutely. If you just have a property reference it would still be sweet:column("Name", Customer::name) - t
thomasnield
09/03/2016, 6:08 PMAnd alternatively do
, correct?column("Name") { it.value.name } - e
edvin
09/03/2016, 6:08 PMSame if you also want to further operate on it:column("Name", Customer::name) { more here } - t
thomasnield
09/03/2016, 6:08 PMBoth would be supported - t
thomasnield
09/03/2016, 6:08 PMOh - t
thomasnield
09/03/2016, 6:08 PMCool - t
thomasnield
09/03/2016, 6:09 PMBut if you wanted to get the
block with the{ more here }
version, you would have to usecolumn("Name") { it.value.name }
correct?apply() - e
edvin
09/03/2016, 6:10 PMYes. That's the down side. - t
thomasnield
09/03/2016, 6:10 PMI think its still worthwhile - t
thomasnield
09/03/2016, 6:10 PMBecause we streamline majority of cases - e
edvin
09/03/2016, 6:10 PMAnd this might be confusing. Are you just operating on the column or are you returning a value for the value factory? - t
thomasnield
09/03/2016, 6:10 PM
specifies an action rather than a block to manipulate themenuitem { }
, FYIMenuItem - e
edvin
09/03/2016, 6:11 PM@Ruckus What do you think about this? - t
thomasnield
09/03/2016, 6:11 PMI see your point though - t
thomasnield
09/03/2016, 6:12 PMI think we should put this to a vote.