@ron Right 🙂

@thomasnield All the column() functions should take an op as the last argument so we can avoid the need for

apply

all together. I'm also quite sure that the best approach is to write

column("Name") { value { it.value.name } }

instead of

column("Name") { it.value.name }

- even though it looks corny as a one-liner, and you'd some times need to write just a little more, this is the most flexible/consistent approach.

@User uploaded a file: Untitled and commented: something like this?

@ron That's right. It reads a lot cleaner IMO.

But you don't need to use this if you have properties or even a pojo:

column("Name", YourObject::name)

Okay I'm cool with that

@thomasnield This is free though:

column("B Column") value { it.value.B }

That's okay, looks odd

Hehe, yeah 🙂

Im cool with whatever as long as explicit typing goes away and it doesn't have to be an ObservableValue

So the proposed approach is great

OK 🙂 Let's hear from @Ruckus as well before we make the change.

do you know that feeling when you look at code and you go like “wow thats ugly"

@User uploaded a file: Untitled

You could use filter/map more and assign the result to photolist directly. Also, a list of valid extensions and checked against

validExtensions.contains(file.name.toLowerCase().substringAfterLast('.')

would also remove some of that uglyness 🙂

I cant assign it directly to photolist as I need to find out if the photo is already in the list from earlier scan

the list of validExtensions is an excellent idea though

@ron Can't that be one of the filter conditions?

filterNot { category.contains(it) }

Category

could have a

contains

function that puts the "contains" logic in the right place and removes it from the filter expression.

@thomasnield @Ruckus I committed the column builder change so we can try it out. It's a bit abstract to just talk about it, better to play with it and see how it feels. It sure cleaned up a lot of my existing code at least 🙂

If we make this change we should consider releasing the next version as 2.0.0 to comply with semver. In that case it would be nice to include the new view transitions also.

I agree with that

😉

filter and map I have not done much with it, last three years the code base I work on with customers is at most 1.6, some even still have 1.4

That's a wonderful new world to step into then, Ron 🙂

I do all these side projects to at least try to stay uptodate a bit

How did we get by without this?!

@User uploaded a file: Untitled

in all the filter and map stuff how would you handle recursion?

@ron You would need to split your task into several sub tasks to deal with recursion