Does the

fx:controller

have to be the

UIComponent

loading the FXML?

or if I have

class MyView : View() { ... val controller = MyController by inject() ... }

, can I have

fx:controller="package.MyController"

?

No you can't. That would certainly be possible, but the main issue here is that I need to know up front if you put

fx:controller

in your FXML file, because if you didn't, I need to call

setController

first so that

FXMLLoader

will wire up event listeners etc correctly.

I was thinking we could override the input stream and make sure we skip the

fx:controller

attribute if we're at the root element, but that would be hard/error prone I think.

Indeed

It would also be possible to fix if we would subclass FXMLLoader or reimplement, but I don't think we want to do that.

I just need a small hook to make it happen, but there is nowhere to hook into right now 😞

Lame

Maybe @jonathan knows something more about that?

Too bad really. I think FXMLLoader should be extensible, not completely closed like it is now. If no

fx:controller

attribute was found,

controllerFactory

should be called none the less.

True

I didn't want to bother him with it, I guess he has plenty to think about before Java One 🙂

the answer is probably no

and also, yes, JavaOne is all-consuming

improving FXML API is a good goal, and something I’d love to see community contributions on

@jonathan Sorry to drag you away, but thanks for the answer none the less.

np

Thanks @jonathan 🙂 Maybe we will come up with some suggestions for improvements 🙂

That would be great - I’m always on the look out for people keen to improve my areas

If

loadListener

wasn't private, we could use that to call

setController

once the root element was loaded and there was no call to

fx:attribute

. But sadly, that's private as well, and probably removed in JDK9 I guess.

(It's setter is public and deprecated, named

impl_setLoadListener

)

Hm! I just found out that

RT-21228

is about promoting LoadListener to public API!

Nice

Do you know where the public bug tracker for JDK9/OpenJFX is?

Do you want this? https://bugs.openjdk.java.net/secure/Dashboard.jspa

Thank you 🙂

Haha, I can't even find the source code for OpenJFX, maybe time to go to bed.

http://hg.openjdk.java.net/openjfx/9/rt maybe

@edvin Is it possible to use an FXMLLoader controller factory to generate the Kotlin controller object? I use this with Google Guice and Spring w FX

@carlw The controller is already created at that stage, since the

fxml

delegate is a part of the controller class, but it is possible to return that instance from a controller factory. The issue is that the controller factory is only consulted if the user actually put the

fx:controller

attribute in his FXML file. If he didn't, you need to call

setController

before you load the file.