@User uploaded a file:

@User uploaded a file: Untitled

Maybe it's as simple as that? The builder logic can now be contained within the ViewModel

I will try it out

Do that 🙂 I'll be back in a bit.

ok

If it would help you, we can add an automatic on-commit step that is always done on commit, so that you don't need to remember to call

model.updateEntry()

that is what I was looking for actually, in the current viewmodel, just committing is enough

I added an

onCommit

function to do that. Simply rename

updateEntry

to

onCommit

and add override modifier, then you can just call model.commit()

you pushed it already?

that program (keepass) is also why I am so interested in OSGi to see if I can use that to support plugins

Yes 🙂

Cool

I updated the wiki and the guide as well.

I just found out that the

fx:controller

attribute support causes side effects with

@FXML

annotated properties. I might need to revert it.

I reverted it, but at least we support the

hasControllerAttribute

parameter now.

@User uploaded a file: and commented: This is plain JavaFX with Kotlin. Is this a use case that TornadoFX supports? The Controller is defined in the .fxml. It seems like the latest build will ignore the value.

@carlw Well, you can do exactly what you did here, but I don't think it would make sense to return a

View

or a

Fragment

as the controller by dictating it in the FXML file. If you think about it, the whole point of the

fxml

delegate is to load an FXML file and become the controller for that FXML file. Consider this example:

@User uploaded a file: Untitled

Here, the

MyView.FXML

file is loaded, and this instance of MyView becomes the controller for that FXML file. If you want to specify

com.mypackage.MyView

in the FXML file so you can enjoy code completion and help when you use scene builder, you are welcome to set

fx:controller="com.mypackage.MyView"

in there, but then you need to change the fxml delegate to:

override val root: BorderPane by fxml(hasControllerAttribute = true)

(or simply true)

The reason for this is that you do not want the

FXMLLoader

to just arbitrarily instantiate a new View and set that as it's controller, because then the

button

would not be injected correctly, and any action would not be called on the instance of the View that you already have instantiated.

Basically, I can't think of a use case where it would make any sense to let the FXML file dictate the controller, if that controller is a View or a Fragment. If you want to load an FXML file that should not have a View or Fragment as it's controller, you can embed that inside a View by using the method you did in your example though:

@User uploaded a file: Untitled

@carlw If that last pattern is at all useful to you, I would be happy to create a more convenient way to support that in a cleaner way. But is there a use case for that - or did I misunderstand you?

If that last use case is valuable, we can add a function called

loadFXML

that returns both the node and the controller in one swoop:

@User uploaded a file: Untitled

The implementation would basically be:

@User uploaded a file: Untitled

@edvin the tornadofx bundle in the osgi download is that a normal jar? you dont have to massage it to load it in felix?