@ron If you see anything that looks weird, LMK. Don't worry about any pleasantries.

@ron i'm working on the edit mode now. After that, the only functional requirement will be the ToggleButtons at the button. Then a big cleanup to put TornadoFX's best foot forward.

@ron I'm basing the requirements off of reverse engineering FluxFXApp.

oh you are not making Edvin happy 🙂 everything in one file 😉

I don't have a problem with that 🙂

yeah...i'll separate it later

I'm also moving the classes around via nesting.

I will probably have some input when I look at the code though, and maybe we'll even add some more nuggets to the framework to make things even smoother. Just look at how big a difference that

cellFormat

function made!

I jammed all the FXML together because I couldn't get the View() and Fragment() working with the fx:includes at the first try.

Is it a requirement to use FXML, Carl?

The builder syntax is a lot more concise.

And the resulting View will have lots less cruft as well.

I just pushed the editMode change.

I used the existing FXML to get up-and-running quicker.

var idgen

should probably be private 🙂

OK. I suspect it might be cooler to switch to builder syntax when everything else is up and running though.

Sure...I think this should put TornadoFX in the best light. But in practice, I use FXML a lot. Or, more specifically, designers I work with use it.

Instead of

addInput.onAction = EventHandler{

just do

addInput.setOnAction {

I have a few notes from the IntelliJ code review about the SAM constructors.

Also,

selectAll.selectedProperty().addListener(

can be expressed as

selectAll.selectedProperty.onChange {

I forked it and will look at it tonight, gradle does not work from the office

Thx. Keep them coming. I have to run out for a while but will probably get another hour this morning for this.

Sweet 🙂

Also, LMK if something doesn't build. I made some IntelliJ settings for the Kotlin VM that I'm not sure transferred to Gradle.

Also, if you run the reference app (FluxFX), you'll need to downgrade the easy-di dependency to 0.3 (rather than 0.4)

I don't think the author published the later version

Same with

TodoItemListChangeListener

- you don't need it, just do:

items.items.onChange {

OK, I'm just looking at the code for now 🙂

Oooh, instead of all that

if( !contentLabel.styleClass.contains( "strikethrough") ) { contentLabel.styleClass.add( "strikethrough" )

, just do

contentLabel.toggleClass("strikethrough")

.

You might introduce a type safe stylesheet in the end as well, to take it even one step further. I can convert the stylesheet for you if you want.