when you take the todoListView and only change the cellCache to cellFormat it does not format the same

allthough I expected that

@ron Remember that cellCache is only evaluated once, while cellFormat is evaluated a lot of times. cellCache only returns the node that should be rendered for a specific item, while cellFormat can modify that object based on the actual state of the item/cell.

yes I understand that, but the formatting should be the same

Also, remember that for cellFormat to do anything at all you need to assign something to graphic.

I keep forgetting that!

cellCache returns the node that will be automatically set to the graphics property of the cell, but cellFormat does nothing unless you assign to text or graphic.

it feels so strange to assign graphics when you are not doing graphics

Yeah, I think that's a weird name, but it's in the JavaFX API, not ours.

true

OK, I'm off! Later 🙂

I just realized I made a mistake with the

cellCache

parameters. It operated on the Cell and had the item value as parameter. The thing is, the cell can change, so consulting it inside

cellCache

could have unintended consequences. It has to be fixed.

are you not supposed to be painting a cabin?

For example, if you add an event handler to the cell inside

cellCache

, it might end up on another cell down the road.

@ron Yeah yeah.. but I can still think about this!

hehe

Back to work, will look more at this later.

well I switched from cellCache to cellFormat

@User uploaded a file: Untitled

I think you will need a ListCell implementation to react to the edit events... Not sure yet, will check though.

rofl I dont want a listcell implementation 🙂

Then we need to add specialized editing support. That might be a nice feature though...

Or you might be able to do it with just a

cellCache

and

setOnEditStart

handlers etc. I will check tonight.

hi. i just pushed a change to my branch that wraps the cellCache in the controller so that a call to remove an item will also remove the Node objects from the cellCache

I have a class TodoItemModel that manages an ObservableList and a FilteredList

The Controller is a facade that combines the TodoItemModel and a cellCache so that the UI can get at the functionality throughout the app with inject()

My changes don't affect any builder stuff (I'm still on FXML)

So, this brings the custom ListCell down to the following

class TodoItemListCell : ListCell<TodoItem>() { val controller : MainViewController = find(MainViewController::class) override fun updateItem(item: TodoItem?, empty: Boolean) { super.updateItem(item, empty) if( empty || item == null) { text = null graphic = null } else { text = null graphic = controller.readCache(item).root } } }

inject() didn't seem to work because I'm not extending the right class