Yes.

wanted to pull your changes 😉

Let me play with this hidden thing for a little while, then I'll modify the sample to use a Fragment for the cell etc.

Even though this works, you still need to pass the cell to the TodoItemFragment, so there really is no better use case than creating a specialized cell...

@edvin where are you working? I'll pull your version to test too

@carlw I pulled ron's sample to look at the CSS yesterday so I just used that. I'll create a PR for it later, but what I commit will not be my recommended approach. I will show that as well 🙂

@edvin @ron Don't forget the counter at the bottom of the page. My TodoItemModel binds to both viewableImagesProperty (Listview) and itemsProperty (for the active count)

I haven't even seen the initial sample yet.. hehe

@edvin @ron I put a listener on itemsProperty. I'd much rather step this down to a StringExpression and bind that

If you pull my version, I went click-by-click against the reference version and trace all the functionality to that

That sounds as a good idea, but I wonder if the resulting application will have the TornadoFX feel 🙂 (Haven't looked at your code yet)

I will do the counter this evening

So here is a version using a Fragment with no ListCell implementation. The down side here is that you need to tell the fragment about the current list cell, so it feels a bit messy:

@User uploaded a file: Untitled

This uses the onEdit event handler I added earlier today to notify the fragment about editing state. The label and textfields know when to show/hide themselves based on the editing state of the Fragment. This is kind if stupid, since a listcell would provide this out of the box.

you created a TodoItemModel too

Yes, because I need to render the View before the TodoItem is known. This also feels awkward.

true

very very true 😉

I'm trying to get this working itemsLeftLabel.textProperty().bind( Bindings.concat( Bindings.size(controller.activeItemsProperty.get()).asString(), " items left" ) ); But it's not getting triggered when the completed is set. That's a change to the item and not the list.

your current solution might not be the best but it seems to work less awkward

Right now,that's part of my ItemFragment...a call to an updateLabel() function when the completed property is checked

@carlw Don't you loose the observability when you call .get() on it?

it's working for the add() and remove(), so i don't think so

adding increments the label, removing decrements the label

I can take a look when I pull it. Will play a little more with Ron's version first.

@carlw What's the URL of yours again?

i'm working here https://github.com/bekwam/todomvcFX

i have an updateLabel() function that everyone can get to which handles the label update when items are added or completed checks are changed

I would love to be able to fire(Event.ListUpdate) to the list to refresh the predicateProperty