controller.completeAnItem() is firing multiple times, throwing off the count.

This video might give some insight into the extra instances. I put a println() in TodoItemFragments init{}

@User uploaded a file: listcellfragment.mp4

I end up with 27 ListCellFragment for 6 items.

My workaround is to get the specific ID pushed up into the ListCellFragment so that I can correlate the completed() call in the model and avoid the duplicates.

I agree with what you said the other day regarding calling back to the MainView (updateItemsLeftLabel()). I've seen the custom event passing get a little bit out of hand as a way of decoupling things (half the updates in JavaFX, the other half in different developer's event passing schemes). So, I was hoping to do this all in javafx binding

@edvin it is as far as I can tell. It actually feels even better than Windows so far. I want to upgrade to Linux Mint 18 but I'll stick with the custom 17.3 build for now.

@ron I'm using Cinnamon. It's pretty slick.

@thomasnield That's incredible.. They finally made it. Have to try that..

@carlw Yeah, you can't do

onChange

inside of

onChange

with listCells, since they are reused, this makes total sense. Move

item.completedProperty.onChange

to

completed.selectedProperty().onChange

outside of the

itemProperty.onChange

(just do it once per fragment in init).

@carlw Let me try that println trick locally..

@edvin I'll try that. Here's what I originally had.

@User uploaded a file: Untitled

@carlw That's how it should be I think.

@carlw Found the bug in SmartListCell. Will fix and commit ASAP!

@User uploaded a file: Untitled and commented: I'll try this after your commit. Right now it doesn't seem to be working although it looks like it's only firing once.

is there already something written about the SmartListCell?

(in the wiki I mean)

@ron Not yet, it's not completely ready yet 🙂

"(just do it once per fragment in init)". ... i think i'm doing it once per fragment, but because there are many fragments referencing an item, it's being added to more than one item

@carlw You are only adding an event handler to

completed

which is is a CheckBox within the Fragment. So if you add an event handler to that CheckBox in init, you only do it once per Fragment. That's what I meant 🙂

We are talking about

completed

in

TodoItemFragment

right?

yes...i think it's best to keep the controller reference out of TodoItem

I agree.

and you're suggesting using eventhandler rather than changelistener?

I... think that would be better.. This is an interesting problem really. I just need to get my head above water here, still swimming after last week. Going to fix this fragment-bug first, then let's look at how to best signal the controller about the completed status change

i'll look for your fix. This seems to be firing a lot. I'll test more later.

@User uploaded a file: Untitled and commented: firing twice (nv=true) for every completed check

@carlw Haha, yes something is completely off here. I "fixed" the bug, which introduced even more horrible behavior. I'm not completely myself again, having a hard time consentrating still, I might need to just let this lie for a day or two, because right now I do more harm than good it seems 😬

@edvin np. the head of my fork is working with regards to the lower-left label and the completed checkboxes for reference. it has the MainView reference