I'm now updating the "items left" label based solely on list changes 🙂

Everything is working now. I think I'd like to look at a completely clean implementation of this app, without trying to adhere to the over engineering in the other samples. It will me easier to understand and showcase TornadoFX much better IMO.

But first some sleep 🙂

sounds good. when you get back online..you're deducting the completed checkbox from the items left, right? that's not a list change as much as it's a control or item change

I simply make sure the cell calls startEdit()/commitEdit() when you click the completed checkbox. This makes sure the ListChangeListener attached to the items list is fired, and the label is updated.

Concerning the viewModel generation

(hi btw)

@User uploaded a file: Untitled

The storyModel is generated with the plugin

the properties from the baseclass are not added, is that intentional

I can make it look deeper than the first level for sure @ron 🙂

We could add a question popup before the properties are generated. I can't do it now, could you add an issue for it so I don't forget?

it has no urgency @edvin was just wondering, its only two properties

I still need to finish the color picker for the plugin.

I will make an issue

@ron OK 🙂 I won't prioritize it now then, but nice to have the issue there.

I am adding the issue to the tornadofx-idea-plugin repo

done

Thank you!

@edvin I pulled out the mainView.update() calls in my masterbranch and also replaced the cellFactory with cellCache. TodoItemListCell is deprecated so that can be removed too lvItems.cellCache { model.readCache(it).root } I'm delegating to a model function because I have the model cleaning up the cache. If we don't care about a removed object's fragment remaining in the cache, we can decouple this. If this looks good with you, I think the only thing left is to incorporate Ron's changes that replaced the .fxml with type safe builders.

Great! I don't think we care about the removed object's fragment remaining in the cache for this app, considering the small number of todo items one would have in such an app. In any case, the cellCache function will probably be optimized by performing eviction automatically. In fact, that would be a nice little enhancement in any case, so to not confuse readers we should remove the model.readCache thing 🙂

I haven't looked at Ron's builders, but if you incorporate them I can look over it tomorrow, OK?

I'm struggling with another UI app I have that suddenly started crashing the JVM on never Java 8 versions, and I found that the culprit was SWT so I'm removing it and replacing it with TornadoFX 🙂

Added "Concurrency" chapter to "Learning RxJava with JavaFX" Guide.

@thomasnield The screen shots are very dark

@User uploaded a file:

@ron commented on @ron’s file : This is the epub version btw when reading it online it goes fine

Works fine in mobi format

@User uploaded a file: