@carlw I also see no point in wrapping

itemsProperty

in a

Property

at all. We never swap the backing list anyways.

i have the app modifying items and reading from viewable items (filtered list)

just keep it a flat list?

@User uploaded a file: Model Section - Carl

I think that how the ListView wants to filter items is not a concern for the TodoItemModel, so I would like the filtering to stay local to the MainView (that contains the ListView). The controller supplies the data and the listview filters it how it sees fit IMO.

you're not using that binding expression for the ToggleGroup that I originally had?

@carlw I'd like to use the facilities provided by

SortedFilteredList

. It has built in support for this sort of thing 🙂 Actually working on it now.

check out the usage of the numActiveItemsProperty too. it increments / decrements with the add/remove and with the uncheck/check

i was also playing with the functional requirement to adjust the filter when an item is added. for example, going to All or Active when adding an item while the completed filter is on

maybe push the whole #-ing thing into the listview as a readonly count property?

@carlw Yeah, possibly 🙂 My day is so freaking fragmented, I only get 3 minutes here and 2 minutes there - probably won't finish it tonight 😞

ok. i'm happy to pull in your whole app. don't worry about using my classes, but don't forget that we're describing architecture and not necessarily the best ListView component

challenge would be to make the TodoItemFragment not use fxml but a builder

yeah. i'd like to see that @edvin before refactoring listview

I could create the builder as well 🙂

As soon as I get a few consecutive coding minutes

Maybe you can fork my repo, swap the .fxml out for the builder then do another refactor on the ListView with possibly another TornadoFX change

well looking at it, should not be too hard

that fragment is in your repo @carlw ?

yeah. i my repos is working and current with all the edits discussed on this form to date (but still uses FXML)

ok I will fork it and see what I can do

feel like doing some programming tonight

@edvin maybe you can pull from the lestard source and we'll send you pull requests?

that way you can do code review and maybe make things easier?

@carlw your repo is bekwam right?

yes. two a's for you

the master branch or the cellFragment branch?

master

pulled it, replaced my own master with it (all the builder stuff I did, I put in a seperate branch called

oldstuff

) and now pulling and installing the latest of the tornadofx repo

hmmz getting a lot of compile errors