From inside a

Component

you could now do

val jProInstance = (scope as JProScope).instanceId

if you for some reason need to get to the instance id. You could also make a field for the primaryStage and add a method to the scope to retrieve the WebAPI. As I mentioned earlier you could even add a ViewModel in there if you create a limited scope for example to support MDI. @carlw I would love it if you would try this to see if we can support your use case with it. Will polish a bit more and then push it I think. I have tried all my apps (not scope-aware) and had no issues after the rewrite.

@edvin Sure...this would be a small test app with ProjectViews backed by ProjectViewModels that contain different state

Sweet! Very interested to see how that works. I would try it in my CRM app also, but that's a major rewrite because I have so many views.

@edvin i'll add something with collaborating ViewModels. So, when you wire up the ProjectView to a ProjectViewModel and a second ViewModel to the ProjectViewModel, everything comes together as though it were -at-Singleton although there may be a duplicate set of instances around

Really cool @carlw - this is actually a very nice "enterprise" feature.

So you create a new scope for a "root" MDI window you would just do

find<ThatView>(Scope())

where scope could just be an instance of

Scope

like I did here, or a custom version with the ViewModel inside. We might need to add some convenience functions to get to that viewmodel from inside the View/Fragment/Controller though.

From a "scoped" component, you can access shared controllers by doing

val myController: Controller by inject(DefaultScope)

inject

is now defined like this:

@User uploaded a file: Inject with scope support

If you pass it an override scope, it will pass that to find. If you don't, you'll get the component's own scope.

That's the first time I've used an instance variable as default parameter value. Didn't even know it was possible. Very handy 🙂

The

App

class also have a

scope

variable. This should be set in

init

or in

start()

if you override that, but before

super.start()

is called.

Now that I know it's working I will use the weekend to get some samples up and running and publish using JPro!

But first a celebratory beer 😎 🎉 🍺

It's in the

feature/scope

branch if anybody wants to play with it: https://github.com/edvin/tornadofx/tree/feature/scope

I had to abandon ThreadLocal myself because everything was running on the FX thread...you might be ok if you're passing around the scope parameter into all your calls If you call find(MyClass::class)...will you get the properly scoped object (singleton, prototype, customer)?

Most implementations solve the initialization problem by requiring constructor injection

Guice allows you to do both, but if you put an -at-Inject on fields, those members won't be available in the constructor (but will be elsewhere)

And in Spring, I usually put -at-Autowired on the constructor, though it's on some of my fields because not all of my classes have constructor-related initialization (ex RESTful services)

What thread it is means nothing, since I always set the thread local value just before I call

class.newInstance()

so it will "always just work".

inject()

is actually lazy, so it will be pulled in whenever it's needed. This makes it super easy to support circular dependencies, so I've been very happy with it.

Oh and yes, you'll get the properly scoped object if you call find(MyClass:class) because I've put

find

inside

Component

. I had to put some more methods in there that I frankly don't want to have inside

Component

so I'll be working on removing them during the weekend.

The

find

inside component just calls the

find(class, scope)

function with the scope from the component.

Is this the right way to use scope?

@User uploaded a file: Scope Test Case and commented: Fails on "assertEquals" b/c hashCodes don't match

Yes, if you change to

class A : Controller()

. Component doesn't have an equals/hashCode implementation.

I'll add this as a test case

But don't I get back the exact instance?

The reason you get separate instances is that

Component

is not a singleton. It's like

Fragment

in that regards, so you'd get a new instance every time.

However, if you injected a

Controller

inside of

A

, they would be the same instance. That's a better test as well.

let me switch A to Controller