(I deleted my mumbo-jumbo comments above)

It should work now, right?

Controller worked for me. What's the set of scopable objects?

Well, they all support scope, but remember that you would only get the same instance back for singletons. Singletons means subclasses of

Controller

and

View

.

To subclass

Component

directly doesn't make any sense, since it can't be used for anything in the framework. The only prototyped component that makes any sense is

Fragment

. I think I read that in Kotlin 1.1 sealed classes doesn't need to be inside the parent, so for 1.1 I could probably make

Component

sealed to avoid that confusion.

Yeah, just found this in a JB blog post: "For sealed classes we broaden the scope where their inheritors may be defined: before it was only inside the sealed class itself, now it’s anywhere in the same file."

That will be just perfect 🙂

@carlw I added your test to the framework tests btw 🙂

i can push these up too. i have ScopeTest.kt going

@User uploaded a file: Untitled

Look at

controllerPerScopeInInjectedFragments

. Important 🙂

@carlw I just committed some more. If you pull that, feel free to add tests 🙂

Do you envision anything like this?

class B() : ViewModel() { val projectTitle by inject() val projectVersion by inject() } class C() : ViewModel() { val projectTitle by inject() }

Interesting.. injection in ViewModel?

I'll be gone for about 50 min. BRB!

Would like to hear more about this 🙂

ok. i do that a lot and i think it's in bounds since i cross checked that with the mvvm guys

@carlw pinned ’s Kotlin Alt. Take on Form/Fieldset/Field to this channel.

Also, when you get situated @edvin, take a look at my suggestion for #190 which is the Form resizing issue. I pinned a proposed solution involving GridPane to the channel. https://kotlinlang.slack.com/files/carlw/F2VH1MA0Z/alt__take_on_form_fieldset_field.kt

Alt__Take_on_Form_Fieldset_Field.kt

@carlw How do you see

val projectTitle by inject()

working? Is

projectTitle

a

StringProperty

or something? I haven't looked at the Form/Field thing yet, wanted to keep focus on this for now if it's allright 🙂

NP about the Form stuff. I'll focus on the scope stuff too. The Form code is pinned if you want to look it over later

I have data like that set as part of a Guice Module scoped appropriately

it's speaking more to the need for a generalized strategy that would allow a whole object graph to be constructed with find()

It would be easy to support inject in ViewModel, but it feels weird to me. To make a ViewModel injectable however, you could probably just make it implement

Injectable

. I know that's now what you wanted, I'm just thinking out loud.

I know what you mean. It would be great if everything could be modeled as a tree (View -> ViewModel -> Controller) but at some point cycles start to develop and some class of component (the ViewModel) has to carry that complexity

i think we want the Views and Fragments as pure as possible. The same with the Model

That leaves the Controller and the ViewModel (this is why I'm looking into MVVM)

@carlw I agree. We just need to test this and see how it works in real applications, then take it from there. I've done some more work on the integration with JPro now, and it is pretty sweet by now, so tomorrow I'll publish the first sample for the kitchen sink and then look at more use cases for scope/inject etc. Thank you for all your valuable feedback Carl. Bed time here 🙂