yes but i hadn't tried it post merge

Aha!

i wsn't sure if there was a local file option

Another wedding to attend tomorrow, will be offline for most of the day. I'm pretty sure laptops are frowned upon 😁

@carlw I implemented something that used a javascript syntax hl thing in a WebView first, but it just wasn't as nice as the GitHub web page, so I skipped it 🙂 The commit-first-or-404 is a small caveat, but worth it 🙂

Good night!

no problem. i like the tab.

@edvin no worries! Effective innovation (not what JS goes through) should never be discouraged. The guide has been an effective in evolving because it tends to cover only core material. So it actually was not that bad. Now if we documented every nook and cranny in TornadoFX, that would be frustrating to keep up with. Then again sometimes those minor conveniences are gems too.

@thomasnield tbh some of the nooks and crannies can be quite important

I have not had much time lately(as in 2 weeks) and I have no idea what the ins and outs are of all the changes

@thomasnield Great! I will continue to add those gems now, by going through the changelog. A lot of the smaller (but useful) features have been made because one guy needed it, and that guy might be the only one that even knows the feature exists. I actually enjoyed writing again last night, look forward to continuing with this.

@ron Absolutely. I want most of it documented, even if it's just in the index.

I'm off to Oslo to attend a wedding. Will be back tonight 🙂

as last week you said something like "code according to the last best practices" but I lost track of them

@ron I'll be going over every example in the coming days as well 🙂

@edvin For issue #205, I usually put key listeners on the Scene

@edvin Also, mnemonics aren't available on the Mac (setMnemonicParsing doesn't do anything)

one of the things I really miss

We could always add mnenonic support for Mac? :)

not in the paradigma of mac os

(but a touchbar apparently is, go figure)

We could make it work like on Windows/Linux :)

that we can

but did we not already have it with "_File" ?

or am I missing something

You can set the mnemonic parsing but you'll get different behavior across platforms. Alt + F won't work on Mac and you have to hold the Alt down on Linux.

@edvin @ron I agree little stuff needs to be covered, or else they will always be obscure. If you can't find a place to put them in the guide though, just throw them in the Appendix even if their sections are small

Will do @thomasnield :)

Maybe it'a not worth it to play with mnemonics, but it wouldn't be too hard to override the button skin and attach some key listeners to the scene.

Careful with the skins...i maintained an app with an incompatibility between Java 7 and Java 8 because of the com.sun classes. Wrecked havoc in the build and deployment arena. It looks like this is opened up in Java 9. ButtonSkin is public. Scene for me is what developers will want because if by the time you get around to putting the focus on the right control for a KeyListener, you've lost the productivity boost. I put a shortcut for the = key (+) on the Scene containing TableView rather than a key listener on the TableView itself.