https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    12/16/2016, 1:42 PM
    Of course, it should be isBlank
  • e

    edvin

    12/16/2016, 1:43 PM
    But it still doesn't work I think.
  • r

    ron

    12/16/2016, 1:43 PM
    but then it stays disable
  • r

    ron

    12/16/2016, 1:43 PM
    already tried that
  • e

    edvin

    12/16/2016, 1:43 PM
    okButton.disableProperty().bind(booleanBinding(editor.textProperty(), editor.textProperty()) { value.isBlank() })
  • e

    edvin

    12/16/2016, 1:44 PM
    I thought the first parameter should also be considered a dependency, this might be a bug. Let me check. Adding it as a dependency (varargs after the receiver) it works good.
  • e

    edvin

    12/16/2016, 1:44 PM
    I think @Ruckus made this, so I want to make sure I don't step on the way he wanted this to work though.
  • r

    ron

    12/16/2016, 1:44 PM
    that one works
  • e

    edvin

    12/16/2016, 1:46 PM
    I see why it's not working. 
    booleanBinding
    and 
    stringBinding
    have overloads for none-observable receivers, and they don't add the receiver as a dependency (and can only do so if the receiver is an observablevalue)
  • e

    edvin

    12/16/2016, 1:49 PM
    They need to inspect the receiver to see if it is observable, and add it to the dependency list if so.
  • e

    edvin

    12/16/2016, 1:50 PM
    @ron I fixed it in head now. If you pull it you can remove one of the 
    editor.textProperty()
    parameters. Very nice that you found this!
  • g

    gtnarg

    12/16/2016, 1:53 PM
    @edvin - any reason it sits in Properties.kt and not Binding.kt?
  • r

    ron

    12/16/2016, 2:01 PM
    I pulled, installed and it does not work 😞
  • e

    edvin

    12/16/2016, 2:26 PM
    @ron I tried it, it does work 🙂 Did you run against 1.5.9-SNAPSHOT?
  • r

    ron

    12/16/2016, 2:26 PM
    yep
  • r

    ron

    12/16/2016, 2:30 PM
    hmmz Platform.isApplicationThread() sucks 🙂
  • r

    ron

    12/16/2016, 2:30 PM
    sorry doing some investigative coding
  • r

    ron

    12/16/2016, 2:31 PM
    @User uploaded a file: Untitled
    Untitled.kt
  • r

    ron

    12/16/2016, 2:32 PM
    one would expect that if this is called from the server thread it is not on the FxApplicationThread (which it isnt) but I get
  • r

    ron

    12/16/2016, 2:32 PM
    Copy code
    java.lang.IllegalStateException: Not on FX application thread; currentThread = qtp857357263-26
	at com.sun.javafx.tk.Toolkit.checkFxUserThread(Toolkit.java:236)
	at com.sun.javafx.tk.quantum.QuantumToolkit.checkFxUserThread(QuantumToolkit.java:423)
  • r

    ron

    12/16/2016, 2:39 PM
    hmmz it throws it at line 7 where the val dialog is.
  • c

    carlw

    12/16/2016, 2:43 PM
    i wrap up any and all FX code -- including properties -- with a runLater(). You never know who may be listening!
  • e

    edvin

    12/16/2016, 3:03 PM
    @ron That's exactly as it should be. You can't initialize the dialog if you're not on the FX thread 🙂
  • e

    edvin

    12/16/2016, 3:04 PM
    @ron Just wrap everything in 
    Platform.runLater {}
    and don't do all that back and forth business. You might actually be better off putting this interaction in a normal TornadoFX view and show that.
  • c

    carlw

    12/16/2016, 3:08 PM
    @edvin The BitBucket problem I wrote about earlier is the lack of a Docker image that supports JavaFX. I think I'd have to create my own Oracle JDK image plus Gradle in order to get everything to work. I'm not sure if that would be available to everyone who forked my project though.
    Building 42% > bkcourse appcompileKotline: /opt/atlassian/pipelines/agent/build/bkcourse-app/src/main/kotlin/bkcourse/app/LoginView.kt: (3, 8): Unresolved reference: javafx
  • e

    edvin

    12/16/2016, 3:08 PM
    You could now even fire an event asking TornadoFX to show this dialog and perform the required action 🙂 But remember that whatever is subscribing to the event must be initialized already. If it's a controller, you might want to do 
    find<MyController>()
    in the 
    init
    block of the app to make sure it's loaded. From there you could init this box.
  • e

    edvin

    12/16/2016, 3:08 PM
    @carlw Hmm.. that sucks.
  • c

    carlw

    12/16/2016, 3:09 PM
    @edvin the bitbucket feature is called "pipelines". I'm not sure if TravisCI is involved.
  • c

    carlw

    12/16/2016, 3:09 PM
    @ron Who is creating your BridgeFX class?
  • e

    edvin

    12/16/2016, 3:10 PM
    @carlw OK, I see. This was all real easy on Google Compute Engine.. maybe you can choose another integration site or something?
1...642643644...2007Latest