What's the most effective way to specify a max height for @edvin's TableRowExpanderColumn?

@thomasnield That would be to set it on the component inside the expander row, for example if you have a TableView in there.

@User uploaded a file: Configure the max height of the expanded content

Here is my initial thoughts on the EventBus and how it works in it's current form. I hope to get some feedback from you guys!

@edvin oh of course. Thanks!

@thomasnield Did it work like you wanted it to?

@edvin you lost some formatting in the

customerController

class

@edvin I got distracted. I will definitely let you know since I need this pretty bad.

@edvin - overall I think this is a great feature! Is it possible to hide the scope handling (similar to the thread handling)? If an event is created with a scope, could the subscription mechanism not filter the events in the same scope? The code that currently does this in the examples "feels" like boilerplate.

@edvin - under Events and Threading - I would change "Used wrong, you will ..." to "Used incorrectly, you will..."

@User uploaded a file:

@User uploaded a file: Untitled

@edvin please observe the behaviour of the table

@ron Thanks, checking the formatting now.

@gtnarg Thank you, will fix 🙂 My english sucks 🙂

@gtnarg You're right, the scope support should be built in. It will complicate it internally just a tad, but it is worth it. I'll also make the thread option an enum, that will be clearer than a boolean. Very helpful feedback, thank you very much!

@ron Ah, I see. I will fix that shortly, just need to finish the changes to the eventbus. Thank you!

@gtnarg Wow, that was a great addition. EventBus now supports automatic scope discrimination. By default, the

scope

property of an

FXEvent

is null, causing the event to hit all subscribers, just like before. If you supply the scope parameter however, only subscriptions within the same scope will receive the emission. It worked perfectly!

The documentation has been updated as well. Now the

runOnFxApplicationThread: Boolean

parameter has been thrown out, and an enum was introduced instead. To deliver an event on a background thread, you now create your event like this:

class MyEvent : FXEvent(BackgroundThread)

. Much more readable.

Yup that makes it a lot clearer

@ron I'll need some whisky to debug that smart resize thing, gonna have to wait until tonight.. hehe.. I hoped I would never have to look at that code again. It's.. intricate 🙂

You mean delicate😇

@ron Let's call it delicate. But if you want to solve your problem for now, just set a minwidth on those first two columns and you're good to go.

@ron The default minWidth is 10px, so it kinda does what it's supposed to you see.

(This default comes from JavaFX, it's not something I conjured up)

I know that iswhat I will do as soon as the shopping torture is done

Ah.. Mine is about to start. I'm in the office waiting for my wife to come along. Apparently we will engage in gruesome torture by wandering around town looking for random stuff to buy.

Yup that is what we are doing now

I need to get rid of some friends. Would make this whole thing way easier.