kotlinlang #tornadofx

Hey guys we are contemplating a new factory name for the javafx scheduler in rxjavafx. If anybody has thoughts feel free to chime in. https://github.com/ReactiveX/RxJavaFX/issues/45

thomasnield

12/20/2016, 9:39 PM

Hey @edvin tableview does not seem to get along with TextFlow being used for column values. The row bloats up in height with it for no apparent reason. If I set the fixedCellSize on the TableView (my usual hack for this) , then the TableRowExpanderColumn will no longer expand. Is there a way out of this pickle?

thomasnield

12/20/2016, 9:40 PM

I'll see if I can come up with a self contained example tonight

ron

12/21/2016, 12:42 PM

right interesting question I hope

ron

12/21/2016, 12:42 PM

@User uploaded a file: Untitled

-.kt

ron

12/21/2016, 12:43 PM

what do people think of the dateCreated implementation here?

edvin

12/21/2016, 2:53 PM

@thomasnield Interesting. Yeah, if you can create an example I'll try to figure it out tonight 🙂

👍 1

edvin

12/21/2016, 2:56 PM

@ron At first sounds reasonable to use the

itemProperty.onChange

for this, since it's not practical to create a binding towards

item.times.creationTime

. After thinking about it, I think it's better to create a binding for dataCreated directly, since it would be updated whenever the item changes anyways 🙂

edvin

12/21/2016, 2:56 PM

Then you don't need to add another listener.

edvin

12/21/2016, 2:58 PM

val dateCreated = bind { SimpleObjectProperty(LocalDateTime.ofInstant(item?.times?.creationTime?.toInstant() ?: someDefaultValue, ZoneId.systemDefault())) }

edvin

12/21/2016, 2:58 PM

Of course, this would all be a lot more pretty if your Entry object had observable properties, but I know you like immutable stuff so you need to take this extra penalty.

ron

12/21/2016, 2:59 PM

well in this case its not me that forces this on me its the library I am using

edvin

12/21/2016, 2:59 PM

I do wonder if it's a sweeter way to convert

times.creationTime

LocalDateTime

though. What data type is it?

ron

12/21/2016, 2:59 PM

for a year I am fighting this

ron

12/21/2016, 3:00 PM

and I am still not happy with it, I was actually thinking this afternoon to rip out the part I need (opening, decrypting, encrypting and closing the file) and have the rest done with kotlin classes and tornadofx properties

edvin

12/21/2016, 3:00 PM

You could create your own class:

class ObservableEntry(entry: Entry)

. And just to the nastyness in the constructor. Then the model would be clean, and all ui interaction with the object would be clean.

edvin

12/21/2016, 3:00 PM

But what data type is

times.creationTime

ron

12/21/2016, 3:01 PM

its java.util.Calendar

edvin

12/21/2016, 3:01 PM

Oh wow. Haven't seen that in a while.

ron

12/21/2016, 3:01 PM

@User uploaded a file: Untitled

-.java

edvin

12/21/2016, 3:02 PM

In any case, I would create an extension function on Calendar to return the

LocalDateTime

. That would clean up this whole mess, and make sure you only write that once.

ron

12/21/2016, 3:02 PM

that is not a bad idea at all 🙂

ron

12/21/2016, 3:03 PM

as I needed the same for last accessed and lastModification

edvin

12/21/2016, 3:03 PM

fun Calendar.toLocalDateTime() = LocalDateTime.ofInstant(toInstant(), ZoneId.systemDefault())

edvin

12/21/2016, 3:05 PM

Then the binding would be:

val dateCreated = bind { SimpleObjectProperty(item?.times?.creationTime?.toLocalDate() ?: someDefaultValue) }

edvin

12/21/2016, 3:05 PM

And since you also get to throw away everything in your init block, you now have a much neater solution 🙂

ron

12/21/2016, 3:06 PM

yup that is how I will do it, thanks another thing learned

👍 1

ron

12/21/2016, 3:06 PM

brb