@edvin So, adding the elements will have a number of collisions. For example,

button

is both a class (

.button

) and an element (

Button

). What should I do in this case?

For conflicts with classes and pseudoclasses, I just appended

Class

to the class version (so

:right

is

right

and

.right

is

rightClass

), but those were few and not as commonly used.

Ouch...

Should I only add the element selectors for things that do not have a built in styleclass?

That will mainly be `Pane`s and other layout containers.

I'm not sure what would be best..

Maybe we should add the element constants in a separate object, so that it's completely clear that you're referencing an element, and there can be no conflicts?

Elements.AnchorPane

for example? Then it might not be so weird to use the proper case either.

I could do that. Would you want to use proper case then?

I'm torn.. hehe 🙂

(If we were going to use proper case, we technically wouldn't need the Elements wrapper, but it may be good to keep anyway.)

I think it would be confusing to have them both in the same scope.

Do any of these elements have specific styling in modena btw or are they completely unused?

The ones that are currently in there (

AnchorPane

,

BorderPane

,

FlowPane

,

GridPane

,

HBox

,

Pane

,

StackPane

,

TilePane

, and

VBox

) are used in modena, but only to fix a padding issue when they are the only content of a

TitledPane

.

Ah, just found it.

-fx-padding: 0.8em; 🙂

Yep

(I actually really hate that "fix" and clear it out whenever I put a layout container in a TitledPane 😛 )

By the way, I often see people confused about why there is no hbox/vbox cssclass. People expect those containers to have a default cssclass, but they didn't do it since they are elements. This should be mentioned in the guide.

I expected that too

Me too 🙂

It's unclear because most things in JavaFX do get a default style class.

Technically both

.button

and

Button

will target all buttons

Yes. I actually contemplating adding vbox/hbox styles automatically through the builders.

@Ruckus Would anything like a resets.css help?

They should have just stuck with one or the other if you ask me, but it's not my call.

Maybe we should just keep them in the same space with proper case.. then there will be no collisions, and it should be fairly easy to explain, since all elements start with an uppercase letter. Sorry for the back and forth @Ruckus

@carlw That's basically what Modena was designed to be, just with some weird (and inconsistent) decisions.

Do we know how these elements are implemented in the css engine? Can custom nodes be styled by the element name by default for example?

@edvin It's all good. These are annoying issues to solve, so the extra input is greatly appreciated

Modena is like the browser's default stylesheet, right? resets.css is the web developer counter measure