https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • p

    permalmberg

    01/03/2017, 7:39 PM
    sure'
  • e

    edvin

    01/03/2017, 7:39 PM
    @permalmberg Where is 
    ComponentView
    added to it's group?
  • p

    permalmberg

    01/03/2017, 7:40 PM
    just a moment
  • e

    edvin

    01/03/2017, 7:40 PM
    I found it.
  • e

    edvin

    01/03/2017, 7:40 PM
    And I found the issue.
  • p

    permalmberg

    01/03/2017, 7:40 PM
    oh, do tell 🙂
  • e

    edvin

    01/03/2017, 7:40 PM
    Line 24 in 
    ComponentPalletView
    you do: this += ComponentView(0.0, 0.0, it)
  • e

    edvin

    01/03/2017, 7:40 PM
    You instantiate the Fragment manually, using your own constructor.
  • e

    edvin

    01/03/2017, 7:40 PM
    Hang on.
  • p

    permalmberg

    01/03/2017, 7:41 PM
    Yes, there is also another place I instanciate and add them
  • e

    edvin

    01/03/2017, 7:41 PM
    Fragments are meant to be injected or looked up using find. I think some initialization is not being performed, checking.
  • e

    edvin

    01/03/2017, 7:42 PM
    Yes, 
    Component.init()
    is not being run.
  • e

    edvin

    01/03/2017, 7:42 PM
    If you add 
    init()
    to the 
    init
    block of 
    ComponentView
    and see if that fixes it?
  • p

    permalmberg

    01/03/2017, 7:43 PM
    testing
  • e

    edvin

    01/03/2017, 7:43 PM
    This is not sexy, I'll try to make sure you don't need to call init() manually though.
  • p

    permalmberg

    01/03/2017, 7:44 PM
    yes, now the subscriber works
  • p

    permalmberg

    01/03/2017, 7:44 PM
    can I use find() and pass constructor arguments?
  • p

    permalmberg

    01/03/2017, 7:45 PM
    Ah, seems I can
  • e

    edvin

    01/03/2017, 7:46 PM
    No, they are not constructur arguments, you can pass named arguments though: 
    find<ComponentView>("firstArg" to 0.0, "secondArg" to 0.0)
    etc. Then you can get a hold of them in 
    ComponentView
    like this: 
    val firstArg: Double by param()
    .
  • e

    edvin

    01/03/2017, 7:47 PM
    I like ViewModels better.
  • p

    permalmberg

    01/03/2017, 7:47 PM
    uhg, that adds boilierplate
  • e

    edvin

    01/03/2017, 7:52 PM
    That's why ViewModel or Scope is a better option 🙂
  • e

    edvin

    01/03/2017, 7:53 PM
    There are some catch22's involved with the init() function. I'm not sure it's possible to change that.
  • e

    edvin

    01/03/2017, 7:54 PM
    But you can of course just call init() and keep your constructor params as you have them now.
  • p

    permalmberg

    01/03/2017, 7:54 PM
    well, it's not meant to be done this way so it'll bite me eventually
  • p

    permalmberg

    01/03/2017, 7:56 PM
    I suppose I have to let the VM be assinged via 
    by param()
  • p

    permalmberg

    01/03/2017, 7:57 PM
    that'll work just fine
  • p

    permalmberg

    01/03/2017, 7:57 PM
    then I can create the views via find<>()
  • e

    edvin

    01/03/2017, 7:57 PM
    It really irritates me that we need that init() function, but the only way I can get around it is by either adding a type parameter to View/Fragment, or loose the type on the root it seems.
  • e

    edvin

    01/03/2017, 7:57 PM
    Yeah, that's probably best, Per.
1...710711712...2007Latest