Well, technically it should be called

overlayPaint

, since it can be a gradient as well. And the Paint encapsulates the opacity of a Color, so I don't see a problem with that.

ok

shouldnt overlayColor not be a

Color

?

it should be a

Paint

It is assigned to

GraphicsContext.fill

which is a

Paint

.

@User uploaded a file:

easy on the eye

Haha 🙂 Perfect! I think it's better that it's configurable that way, but we might need to throw IllegalArgumentException for some colors. 😁

throw IllegalArgumentException(”that color? are you NUTS!”)

Hehe 🙂 Submit a PR when you're ready then? I'll go offline for a bit, need to eat and work out.

ok

@ron The adhoc thing should probably be called

adhocInternalWindow

to match

adhocWindow

?

you are right, I will change it

My initial suggestion was bad, sorry 🙂

@edvin What's does the adhoc* mean?

its a fragment or a window with a builder instead of defining a view or fragment

openInternalAdhocWindow("lock", escapeClosesWindow = false, closeButton = false) { vbox { alignment=Pos.CENTER; // prefWidth = primaryStage.width*0.9 // prefHeight = primaryStage.height*0.9 form { fieldset { field("password"){ passwordfield() } buttonbar { button("unlock") { setOnAction { closeModal() controller.startIdleTimer() } } } } } } }

Used like one would use an anonymous inner class?

yup

@edvin Any technical reason why the TornadoFX kotlin code is in src/main/java instead of src/main/kotlin?

@edvin if you're still taking naming suggestions about AdHoc, I'd go with "Builder" as in BuilderFragment,builderFragment, and builderWindow which implies that this is a special Fragment based on a Builder.

Is there a way to exclude properties in a ViewModel from affecting the isDirty-indicator?

I have

val x = bind(autocommit = true) { component.observable(IComponent::getX, IComponent::setX) } as DoubleProperty

but although it has

autocommit = true

it still causes

dirtyStateProperty()

to change.

@edvin This feels like an oversight....

@permalmberg there is a property:

val ignoreDirtyStateProperties = FXCollections.observableArrayList<ObservableValue<out Any>>()

on

ViewModel

@edvin strange behaviour when closing an internalWindow:

@User uploaded a file:

@carlw There was a reason, I think it had to do with javadoc generation for the maven plugin.

@carlw Nice, I like that. Builder is better than Adhoc.

@permalmberg Grant is correct,

ignoreDirtyStateProperties

is the way to go. I'll look into the autocommit bug now.