I would start doing semver after 2.0 tbh

update the minor (the 1.x) when you break

That sounds like a plan. So 2.0 would be a cleanup version and then we move to semver. There are some naming inconsitencies here and there as well, would like some help to clean that up as well before we do.

@ron That's actually what we did the last time, so we'll do that now as well.

I might commit 1.6.0-SNAPSHOT soon then 🙂

awesome

Generics are harder in Kotlin than Java when you get to the hairy cases.

the parameter map is of type Any-> Any? for that reason. Trying to make it

KProperty<*> -> Any?

but it seems impossible.

It can't be called meaningfully if I do that.

If I commit 1.6.0-SNAPSHOT - could you guys test it against existing code with parameters, and see how much hassle you have converting it?

@User uploaded a file: and commented: What's the proper way of making the parts of a

splitpane

fill to the entire width? Look at the right side where there is a lot of empty space to the right of the table views. My

splitpane

is defined as

splitpane {
                add(ComponentPalletView::class)
                add(DrawingSurfaceView::class)
                add(PropertyView::class)
            }

The

DebugView

has a

borderpane

as root.

You can convert

myParam to value

to

mapOf("myParam" to value)

or better:

mapOf(MyViewType::myParam, value)

@edvin Sure, once I nail this layout problem

need to head out for two ours, but I'll gladly test it against my code

Great!

@permalmberg I don't dare to switch focus now, but can look at the layout thing later 🙂

@edvin Fair enough 🙂

Release 1.5.10 without the break then 1.6.0-Snapshot with the API break

back in a few hours

I made a mistake with one param signature, committed a fix.

Ah.. the satisfaction it gives to modify your code to the new param syntax is worth the break alone. You will feel warm and fuzzy doing it, I promise 🌪️ 😎

@User uploaded a file: SplitPane example and commented: @permalmberg - does this address your question?

@permalmberg - now that I look more closely, it seems that the splitpane is filling the entire width - it is your PropertyView that isn't growing horizontally

@gtnarg that may very well be true.

@gtnarg Yes, you were right. I placed a stackpane as the root and now it fills as desired

@gtnarg Did you see that I messed with the param support? It will affect your PR that we merged. I think this is a much better solution even if it is a breaking change. Let me know what you think.

@edvin

addClass

changed in Nodes? Takes

vararg

now?

@jchildress Yes. Was it not backwards compatible?

You can now pass parameters like:

find<SomeEditor>(mapOf(SomeEditor::myparam, myvalue))

or old school like

find<SomeEditor>(mapOf("myparam", value))

if you feel lucky 🙂

@edvin broke on this type of code