@edvin

saveable

is spelled

savable

@permalmberg: I'll fix, thanks :)

Committed 🙂

@edvin catching up on your webcasts right now...

That Workspace is pretty awesome. I'm curious... is there a way to support multiple docking windows (backed by injected fragments) contained within the

Stage

? Just throwing ideas out there. I would definitely use that.

I got a case study too. I often use

TableView

at work and don't often use Master/Detail setups because screen real estate is precious with our analyst users. Therefore we make TableViews directly editable or have complex editing features, like multi-selecting records and applying actions to all of them. But I see the

ItemViewModel

can potentially be helpful here for managing the dirty state of each record. Here is my use case below:

@User uploaded a file: Untitled

I have two problems:

1) the

cellDecorator

does not seem to be working. It should be making that cell text red the moment it is dirty.

2) I feel like I am using the

ItemViewModel

in a way that is not intended. Typically, the

ItemViewModel

is used for Master/Detail setups and replacing the "selected item" and rebinding properties against it, which is brilliant. But how exactly should it be applied if I want to simultaneously track the dirty state of every record in a

TableView

? And use it for dirty formatting?

As you can see, I also use it to drive the "IS DIRTY" column which is working correctly.

If you see my use case as valid and the

ItemViewModel

is not streamlined for it, is there a way we can extract that dirty tracking functionality into an open class that extends onto

ItemViewModel

? If we want to take it a step further, are there ways we can streamline dirty formatting in a

TableView

too?

@thomasnield Right now you can only dock a single main fragment inside the Workspace (which of course can contain multiple fragments). To support this we would need a docking framework as well. There is a pretty nice one in the works that I would like to take a look at down the road though.

@thomasnield I'll look at the case study shortly. My first thought though is that the

cellDecorator

is overridden by the call to

useTextField()

. They both set the

cellFactory

, but only

cellDecorator

is smart enough to wrap the existing

cellFactory

. Will make sure to mention this in the guide. Will try out your sample soon 🙂

@edvin nice work on the workspace

I do have some questions

I understand the onRefresh, onSave and so on are available even if you are not in a workspace environment?

what do they do then?

@ron You can implement them even if you don't use the worspaces, but the framework will never call them. You can surely still use them and do

button("Save") { setOnAction { onSave() } }

.

@thomasnield Nifty solution to get a dirty state event 🙂 When I think about that, my first reaction was that maybe the ItemViewModel is a bit heavy for this usage. I'll let this stew while I'm at work and try to come up with a nice solution tonight 🙂

I guess this warrants mentioning in the documentation 😉

@thomasnield By the way, in 1.6.0-SNAPSHOT, the ItemViewModel takes an item in the constructor, so you can do

class CustomerModel(customer: Customer) : ItemViewModel(customer)

.

I saw that my PR now has conflicts

@ron Absolutely. I started writing the documentation yesterday, will try to finish it tonight 🙂 So much I want to mention. There is also things to think about with scopes when you navigate back and forth that I need to explain.

want me to sort them tonight

@ron Sorry about that 🙂

@ron Yeah, let's look at it tonight. I'm having a busy day at work.

same here

I might throw a way lot of the keepassFX ui and see what I can do with this workspace thingy