https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • t

    thomasnield

    01/16/2017, 6:49 PM
    Dude this is nice... this is going to enable so much awesomeness in the 
    TableView
    ...
  • t

    thomasnield

    01/16/2017, 6:50 PM
    Is this going to be in the immediate release? I could probably use this as-is and be much better off than I was before.
  • e

    edvin

    01/16/2017, 6:51 PM
    I think we'll make it. If I can't finish it completely as it should be, we can include it in the 
    tornadofx.experimental
    package, and move it when it's complete.
  • p

    permalmberg

    01/16/2017, 6:52 PM
    Good evening!
  • e

    edvin

    01/16/2017, 6:52 PM
    @thomasnield Can you describe how you want the UI to work with regards to commit/rollback functions and dirty hints?
  • e

    edvin

    01/16/2017, 6:52 PM
    God kveld, Per :))
  • t

    thomasnield

    01/16/2017, 6:55 PM
    @edvin I imagine each row domain item will have 
    commit()
    and 
    rollback()
    functions ideally. But let me think about this... maybe these need to be methods in the 
    TableEditModel
    that accept the items as arguments.
  • t

    thomasnield

    01/16/2017, 6:55 PM
    I think for using the dirty formatting, what about using it in the 
    cellFormat()
    and attaching a listener for a specific dirty property there?
  • e

    edvin

    01/16/2017, 6:57 PM
    @thomasnield So we might need to add a column to the far left or right with edit/commit buttons perhaps? And OK, will make it easy to get to an observable for a specific column dirty state.
  • t

    thomasnield

    01/16/2017, 6:57 PM
    What about selecting rows you want to 
    commit()
    or 
    rollback()
    , and then clicking a 
    Button
    on a toolbar? That is typically what I would do at work...
  • t

    thomasnield

    01/16/2017, 6:58 PM
    I think if you make the 
    TableEditModel
    , or whatever we call this, accept items and return ObservableValues through methods that should be pretty flexible for most use cases.
  • t

    thomasnield

    01/16/2017, 6:59 PM
    myTableEditModel.commit(item1)
  • t

    thomasnield

    01/16/2017, 6:59 PM
    myTableEditModel.rollback(item1)
  • t

    thomasnield

    01/16/2017, 7:00 PM
    val dirtyState = myTableEditModel.dirtyStateFor(item1)
  • t

    thomasnield

    01/16/2017, 7:00 PM
    Just some conceptual code : /
  • e

    edvin

    01/16/2017, 7:01 PM
    @thomasnield That should be easy to do 🙂
  • e

    edvin

    01/16/2017, 7:01 PM
    I think I already have all that.
  • e

    edvin

    01/16/2017, 7:01 PM
    @thomasnield Is TableEditModel the right word for this?
  • e

    edvin

    01/16/2017, 7:02 PM
    Maybe it's not so bad.. I don't know 🙂
  • t

    thomasnield

    01/16/2017, 7:02 PM
    What are you calling it now?
  • e

    edvin

    01/16/2017, 7:02 PM
    @thomasnield Exactly that 🙂
  • e

    edvin

    01/16/2017, 7:02 PM
    Actually 
    TableViewEditModel
  • e

    edvin

    01/16/2017, 7:02 PM
    But it's so long 🙂
  • t

    thomasnield

    01/16/2017, 7:02 PM
    Okay, haha, that's what I thought. I think 
    TableViewEditModel
    makes sense. Is there anything about editing it does not encapsulate?
  • e

    edvin

    01/16/2017, 7:03 PM
    Not really, so maybe it's good. Do we need a property that gives you the dirty state of the currently selected row perhaps?
  • e

    edvin

    01/16/2017, 7:07 PM
    I'm creating a lot of stuff at once now, we'll make it lazy once we're certain this is the way to go.
  • t

    thomasnield

    01/16/2017, 7:13 PM
    Yes just prototype the heck out of it now and optimize later. I don't know about the selected row, as mutliple rows can be selected and that starts to step on `ItemViewModel`'s toes
  • t

    thomasnield

    01/16/2017, 7:13 PM
    You might as well just use 
    ItemViewModel
    if you want to track the selected item.
  • t

    thomasnield

    01/16/2017, 7:15 PM
    Taking a break for a moment. But I'll pull your work in a moment and play with it. I really like the direction this is going, but I should probably mess around with it.
  • e

    edvin

    01/16/2017, 7:15 PM
    @thomasnield I added 
    model.commit(item)
    as well as 
    model.commitSelectedItem()
    . Same for rollback. Then it's easy to make a button bar like so:
1...770771772...2007Latest