@thomasnield What do you think? I know you like the

menuitem

builder because it's less code to write. I'll leave it, but should we deprecate it or not? I get questions about why the configured

setOnAction

on menu items doesn't fire, because people take it for granted that that's how the builder should work (like the others).

item

is a bit vague?

@ron Not really when it's inside a Menu or ContextMenu? 🙂

@User uploaded a file: Untitled

this would create two entries per table row?

rollback and commit

I don't see another way, unless we want to break backwards compatibility. In this case, code would still compile, but the actions would start to fire when the menuitem is created, not when the button is clicked. That's an awful failure mode as a result of an API change.

it looks good

@ron Yes

I think so 🙂

with in the context of menu and contextMenu

the "old" one still works too?

It's not available anywhere else.

Yes, now the old ones work. I don't know if we should deprecate or not though.

no 🙂

I added comments to all the menuitem and item builders to clarify this.

I like the old ones

The new ones also rock because they support observable titles 🙂

its nice but it does not solve the one I mentioned this morning

where the amount of items is datadriven

@User uploaded a file: autocompleteText.zip

this is that autocomplete thing I found

called from torandofx

it uses a dynamic contextmenu to show the autocomplete results

@ron What can I type to see it in action?

type in a

P

(capital P)

That looks pretty good.

I agree

Nicely done!