That's weird, why would it have a rest client?

Also yeah it's style sheets and stuff, but you still have to get a good color scheme going and stuff I assume.. themes would make that automatic, versus my programmer sense of style ;)

Client may not be the right word (depending on how you interpret it), but here's some information: https://github.com/edvin/tornadofx/wiki/REST-Client

(I'm not sure how up to date that is)

I agree with the themes. Unfortunately I'm in the same boat when it comes to style 🙂

So you'd just wipe everything between tests, right?

@edvin maybe, I have to take a look

@edvin some of the statements in

App::start()

are needed to init single `View`s. I see the

val view = find(...)

we spoke about. But we also need the other statements (default uncaught exception handler, apply stylesheets, hook global shortcuts, bind title property, create primary scene, set default workspace), I guess.

the JavaFX javadocs speak about the "Application life-cycle" (https://docs.oracle.com/javase/8/javafx/api/javafx/application/Application.html). the JUnit 5 documentation incidentally calls methods annotated as

@BeforeEach

,

@AfterEach

, and

@Test

as part of the "test execution lifecycle" (http://junit.org/junit5/docs/current/user-guide/#extensions-lifecycle-callbacks).

so I guess we could call the corresponding stuff in TornadoFX maybe the

App

lifecycle and

View

lifecycle.

maybe there is already a chapter in the tornadofx guide that outlines the lifecycle. I need to read some more chapters.

ahh, and of course there is also the "TestFX test lifecycle", that is (sometimes surprisenly and unexpected to the tester) different to the JavaFX lifecycle to fulfill test constraints

Dimension.AngularUnits

👍 Reminds me of the

euclid

cargo package for the Rust programming language.

Good day folks

Hey!

I'm struggling with bindings of non-string types, specifically `Int`and

Double

. I have a base class like this:

abstract class BaseProperty<T> internal constructor(val header: String, protected val key: String, protected val defaultValue: T, protected val comp: Component) : ViewModel() {
    var value: T by property(defaultValue)
    fun valueProperty() = getProperty(BaseProperty<T>::value)

    abstract fun updateValue(v: T)
    abstract fun readValue() : T

    fun init()
    {
        value = readValue()
    }

    init {
        valueProperty().onChange {
            updateValue(value)
        }
    }
}

from which I inherit a more specified "property handler":

class IntProperty(header: String, key: String, defaultValue: Int, c: Component) : BaseProperty<Int>(header, key, defaultValue, c) {
	override fun readValue(): Int {
		return comp.getProperty(key, defaultValue)
	}

	override fun updateValue(v: Int) {
		comp.setProperty(key, v)
	}
}

In my

ViewBuilder

(part of the ViewModel-layer) I do this:

override fun show(property: IntProperty) {
        property.init()
        with(myForm) {
            field(property.header) {
                textfield {
                    bind(property.valueProperty())
                }
            }
        }
    }

i.e. I bind to a

BaseProperty<Int>::value

. This is working fine as long as only numbers are entered. As soon as a

.

or other non-numbers are entered an exception is thrown. That is in itself is expected and I need to use a converter for that (I also want to add a validator). This is where I run into problems. The examples in the TFX guide all says to use the format

textfield(model.name) {    }

but I can't get that compile since it can't find an overload that matches - it seems want a

Number

. Do I have any other option than to use

Number

instead of

Int

and

Double

? My backend is in Java so it has no notion of

Number

.

Sorry for the lack of feedback @hastebrot - currently in Lithuania with no computer access!

@permalmberg

SimpleIntegerProperty

and

SimpleDoubleProperty

use

NumberExpressionBase

, don't they? Hence all the

intValue()

,

doubleValue()

convenience methods. Don't know if this is related.

@hastebrot Well, yes but that's not what

.value

is typed to in this case.

var value : T by property(defaultValue)

where

T

is

Int

I must be missing something in how this works...

@edvin (slightly annoyed) when you did not handle my pull request, you did not add the changed we agreed on for the internalWindow and the overlayPaint

I will add those and make a new pull request this was https://github.com/edvin/tornadofx/pull/234

@ron: sorry about that. I had some issues with git and messed up a little. Ok, thanks for the patience.

@ron good catch...that hardcoded color might cause problems for someone implementing a dark theme

@carlw not so much a good catch, my code did not compile anymore

I'll fix it tomorrow tonight I am going to the cinema

Heh, Intellij wants to convert

setOnAction {
                            for (prop in myProps) {
                                if( !prop.commit()) {
                                    break
                                }
                            }
                        }

into

setOnAction {
                            myProps
                                    .filterNot { it.commit() }
                                    .forEach { break }
                        }

but then break isn't allowed and the meaning is different.

how about

myProps.first{ !it.commit() }

or

myProps.filterNot{ it.commit() }.firstOrNull()

@permalmberg - are you still having issues with the bindings?

@ron I was writing about creating the overlayPaint() method itself rather than the missed pull. I had a flashback of my favorite 10 year old (and counting) bug in AWT. They hardcoded a gray background. http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6453521

rofl it still does not support that