that looks like a very comfortable chair and you need to shave 😉

Wasn't planning on an online appearance this morning 🙂

In the default ViewStack mode, I remove contributions when the view is undocked, but in tabbed mode I'm not certain what to do. Should the contributions stay until the tab is actually closed, or should they only be there when the tab is active?

I'm deprecating

closeModal()

in favor of

close()

since it does way more than just close a modal dialog. It will do the right thing for non-modal windows, internal windows and now tabs.

@edvin Sorry I missed so much of the discussion. I'm in meetings all day today (just got a quick break). How much complexity would it add to allow each tab to have a back stack, and let the user enable/disable tabs and navigation independently?

Actually, never mind. The use cases I had in mind were 1) way too niche and 2) easy to switch to either tab or stack based without loss of functionality.

@Ruckus is good with transitions 😉

@ron @edvin The width animation should be quite easy. Let me check to make sure I'm thinking correct.

@edvin Here's a quick example:

@User uploaded a file: Untitled

I think it should be easier than that. I'll have to play around with it later though. I don't have time right now.

@Ruckus Really appreciate it. I agree with @ron that it would be much better with an animation so it would be very cool to get this into the next release!

I updated the example. It seems the cast is needed to get the

animate

call to work. We may need to add overrides to the animate function for primitive properties.

@edvin ^^^

Checking 🙂

Actually, I'm not entirely sure which overrides to add. Double is obviously useful (as is Float), but what about Int/Boolean/etc.?

Lately I've started taking

Number

as param and calling

toDouble()

on it, so we don't need Double/Float/Int versions.

It works without the cast for me.

Unfortunately, this doesn't work in the Drawer use case. I need to query the prefWidth with prefWidth(-1) and then animate towards that, but there are some timing issues. Will look into it.

The JavaFX animation framework is pretty powerful, but it tends to be extremely verbose in all but the most basic use cases. There seems to be weird issues that pop up all over the place.

Yeah, I can't seem to figure out why prefWidth(-1.0) returns the correct width some times, but not always. Grr...

I almost nailed the Tabbed version of the Workspace, just one more small feature and I'll turn my focus to the anim completely. 5 mins.

Sounds good. I'll try to help where I can.

As far as the cast goes, I know it works, but it would be nice if it worked without the cast. You can currently use the animate property without cast on String, Object, and Boolean properties, but number based properties require a cast (thanks to how JavaFX does the awkward

Number

extensions).

Not sure I follow. I removed the cast from your code above and it still runs great.

Really?

I must be doing something wrong

Indeed, it works for me too.

I must have had a typo

Sweet 🙂