@gtnarg Do you mean dragging on the TableView will select a bunch of cells before getting to the drop target?

I’m not sure what the behaviour would be exactly...

@hastebrot Should we make the

config

backend pluggable?

@gtnarg You're correct, it would "interfere". Drag and drop would work just fine, but cells would be selected as you drag over them. It's probably not a good idea to combine the two.

I use DND between two tables to move subscriptions from one customer to another actually. It works great and is very intuitive. Just open two workspaces, search for the source and target customer, click the subscriptions tab on both an drag stuff over.

@thomasnield So glad to hear it :))

Maybe if I could detect that a drag has started, I could stop selecting, but I don't think I can get that information from the mouse event. Checking..

According to the docs, once you start a drag and drop operation, you won't get mouse_dragged events anymore, you will get DragEvents, so actually it might just work just as it is.

@edvin config backend pluggable: customizable would be good. I thought about how to handle multiple config files (for manufacturing defaults, system-wide defaults, user configuration). or maybe config validation and schemas.

So, I could define a

class WorkspaceConfig : Injectable

and share it between components via

by inject()

delegate machanism?

I would probably bind the property setters in

WorkspaceConfig

with TornadoFX's

config

object

Meh,

inject()

wants a

Component

. So I use

class WorkspaceConfig : Controller()

instead.

You can also do

Component(), Injectable

if you don't need what

Controller

provides. I'll have a look at

config

shortly to see if we could make it pluggable easily.

The current "contract" for

config

is just a

Properties

object.

Properties

is not final, so I could for example just make it look for a

ConfigProvider

injectable and use the

config

object returned from that for a given Component?

You'd just need to provide a special

Properties

object that implements

load

and

store

.

It seems we're missing a builder for

SplitMenuButton

. Anybody want to give it a go and create a PR? 🙂

I think something broke my keepassFX app

building and testing against several tornadofx builds

@ron Ouch, sorry! Let me know what you find.

@edvin I noticed there is an internationalization chapter in the guide. Wasn't that covered in FXML chapter?

I will I started with checking out the commit where you merged my PR, that one works

@thomasnield I'm not sure. There is specialized FXML support as well as the ability to access internationalized properties from components. Is that already mentioned in there?

@ron Thanks Ron, sorry about that. Can you tell me what error message you get?

from this commit bbdfb072ff0a53c55c7fb8df663fb6e7fe129ef7 the tests fail

@edvin yeah I covered internationalization somewhat comprehensively in FXML chapter.

Maybe chapter needs to be renamed to "FXML and Internationalization"

@thomasnield I don't know if that makes sense, but maybe we should extract the non-FXML-related info on i18n and put it somewhere else?

@User uploaded a file: Untitled

this is what I get against tornadofx master

I am only recompiling master, not doing anything on my code