nested FXML views of arbitrary depth?

Huh.. that worked 🙂

@carlw Just one level has been impossible until now. To be more specific, you couldn't get to the controller of a nested FXML file. Now it works with fxid. Check out https://github.com/edvin/tornadofx/issues/243

@carlw I just added another comment 🙂

@edvin if you go the custom parsing route, i was thinking that an include() Type Safe Builder might help bring the FXML in sync with TornadoFX. Support the following syntax... vbox { include("myfxml.fxml") button("Press Me") }

then, you walk through the fxml tree and invoke type safe builders with the include called recursively

That would actually be pretty easy to do.

I'll test some more on what I have now and commit. Can you test against any fxml TornadoFX code you have?

brb

I'll test tonight...The preferred include() would still be to put a Fragment in the builder, but this include() would be a strut to help with the task at hand

Absolutely. No reason not do it, it's just a few lines of code.

I'll let you know when I've committed 🙂 Still a lot more testing I need to do.

i think it might be a little easier to program: .fxml -> type safe builder model w. include -> scene object graph

@carlw This might be a cheap way to implement `include()`:

@User uploaded a file: `include()` builder uses a Fragment under the hood

yeah...go from <vbox><fx:include/><button/></vbox> -> vbox { include() button() }...then invoke this method when you do an override root assignment

Will put Alyssa to bed and then create a couple of tests for this.

ok. i think there are two test cases that need to be covered w. respect to the controller 1. All the -at-FXML items are in a single controller file. Many .fxml files, but only one controller 2. FXML items in individual controllers

I've committed it now, but I suspect it's not complete.

no, but i think if you can first mimic the behavior in a pure TornadoFX way, the FXMLLoader.java problem will be solved

Do you have time to write a test or two, Carl? You know better than me what we should test.

I will tonight. i'm in PHP / Bootstrap hell right now

Hehe.. enjoy! Everything seems to be working now, even in my CRM, but the way this is done is a bit hairy, so we need to test a little better.

is there fxml in your crm?

Yes, because I started out with it (before there were any builders), so I have several views that are FXML still.

it's fair to say what's present in javafx is nice, but it isn't getting new features at a particularly high rate. that pretty much sums up the java platform: they focus a lot on core quality and add new features slowly. i don't expect big new APIs to be added to javafx at this point, i think .... they've built a decent replacement for Swing and things like APIs that rely on cloud services (like geolocation) aren't really what Java is about. Better to just use third party libs for that.

@mikehearn I totally agree.

Cloud / Geo Location moves to fast for the JDK, it would be a giant mistake to include stuff like this right now. It would be obsolete before it was GA.

well, i think the real issue is not so much that it moves too fast, it's that the providers come and go

and jdk releases can last in production for, like, a decade. that makes depending on particular servers to stick around rather risky.