https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    02/14/2017, 3:11 PM
    I merged your test and made one small modification, so pull before you change.
  • c

    carlw

    02/14/2017, 3:11 PM
    yes. did you add fx:controllers to the included code?
  • e

    edvin

    02/14/2017, 3:12 PM
    No, I didn't touch it 🙂 Wanted to see if you do it differently from me. I don't have much experience with FXML, and there might be stuff I don't know about.
  • c

    carlw

    02/14/2017, 3:13 PM
    i see.. you didn't like my string compare. i don't think kotlin supports a generics comparison which would be better than both syntax (assertTrue( obj is ListView<String. ))
  • e

    edvin

    02/14/2017, 3:14 PM
    That's right, the String type is erased. The String compare was not necessary though IMO 🙂
  • e

    edvin

    02/14/2017, 3:14 PM
    Better to keep it type safe 🙂
  • c

    carlw

    02/14/2017, 3:16 PM
    @Ruckus Have you seen any RFEs for "obj is ListView<String>" or is that too ingrained in the language?
  • e

    edvin

    02/14/2017, 3:17 PM
    The JVM erases it. Not possible.
  • e

    edvin

    02/14/2017, 3:17 PM
    They talked about complete refied generics at some point though. Don't know what kind of magic they would have to employ to make that happen.
  • r

    ron

    02/14/2017, 3:18 PM
    talking about the JVM look at this sonarcube issue I found in the code here at work:
  • r

    ron

    02/14/2017, 3:18 PM
    Copy code
    Don't try to be smarter than the JVM, remove this call to run the garbage collector
  • r

    ron

    02/14/2017, 3:18 PM
    oh and the code?
  • r

    ron

    02/14/2017, 3:19 PM
    @User uploaded a file: Untitled and commented: crying is allowed
    -.java
  • c

    carlw

    02/14/2017, 3:19 PM
    @edvin maybe there's something Kotlin can do earlier like they did by adding the star operator?
  • c

    carlw

    02/14/2017, 3:19 PM
    @edvin anyway...should I update the ComposedForm test case with Kotlin controllers? Do you want the included items to be of any particular TornadoFX type?
  • e

    edvin

    02/14/2017, 3:19 PM
    @carlw Maybe they can attach some debug metadata or something somehow.
  • c

    carlw

    02/14/2017, 3:20 PM
    @edvin build up a preprocessing symbol table, etc
  • e

    edvin

    02/14/2017, 3:23 PM
    @carlw Yeah, just update the existing test case. Doesn't matter what the types are I guess.
  • c

    carlw

    02/14/2017, 3:23 PM
    @edvin but i'll need fxid(), right?
  • e

    edvin

    02/14/2017, 3:24 PM
    Yeah, to access the controller in the surrounding controller.
  • e

    edvin

    02/14/2017, 3:26 PM
    @User uploaded a file: Untitled
    Untitled.kt
  • c

    carlw

    02/14/2017, 3:26 PM
    the fx:include items will have a subclass of View() in their fx:controllers?
  • e

    edvin

    02/14/2017, 3:27 PM
    @User uploaded a file: fxml
    fxml.xml
  • e

    edvin

    02/14/2017, 3:28 PM
    Yes, but they might just be 
    Controller
    as well, they don't need to be a View. Maybe we should test both.
  • c

    carlw

    02/14/2017, 3:28 PM
    will i be able to use fxid() in that class?
  • e

    edvin

    02/14/2017, 3:29 PM
    I made one mistake above. Since 
    FormView.fxml
    is included with 
    fx:id=form
    , the controller will be available as 
    formController
    . This is a JavaFX thing I believe. Updating the example above.
  • e

    edvin

    02/14/2017, 3:30 PM
    In MainView.kt: 
    val formController: FormView by fxid()
  • c

    carlw

    02/14/2017, 3:31 PM
    i had expected this to work, but I'm getting an loader error that search can't be found
  • c

    carlw

    02/14/2017, 3:32 PM
  • e

    edvin

    02/14/2017, 3:32 PM
    Is 
    tfSearch
    in an included fxml?
1...880881882...2007Latest