What is the best place / moment to set the application icon in tornadoFX. Currently I have it in the

onBeforeShow()

You mean @edvin hasn't provided the onBeforeTheUserLooksAtTheSystemTray() yet?

It can happen in start or onBeforeShow. As long as the fx lifecycle is active and the window isn't shown yet you're good.

I'm on my way back from Switzerland. Met some JavaFX people there

There is a big cafe lounge called Unternehmen Mitte (some swiss call it their public living room) which is in an old bank building. In Markthalle Basel one can eat a lot of diverse Street food.

Ja needs to be in the onbefore the FX lifecycle is not active yet during init

@carlw I was talking about the application icon not the systray

@edvin that's ok. the joke still works

@ron dontFaultMeIfIUseItAgain({someOtherContext})

@edvin how about I change App a tiny bit and have the applicationIcon and the application name as possible arguments?

@hastebrot I saw you met Andres Almiray? Cool!

@ron We already support an icon, but you want to improve the syntax, is that it?

Yes also Mac needs special handling

App.kt has the stageIcon, that works for windows and linux, but not for the mac

@carlw while looking for a solution to set the application name in javafx I found this blogpost http://bekwam.blogspot.nl/2015/11/mac-menus-in-javafx-app.html

but you can now use Menubar.setUseSystemMenuBar to do that

@ron I don't follow.

addStageIcon

works for Mac as well, I've used it many times.

For the stage not for the dock

@ron Can you post a picture of the mac menu with useSystemMenuBarProperty set? Does it also have the app's name next to the apple icon?

i think i recommended the swing route because of the java.exe

@edvin - I was going to update form functionality in tornadofx-controls. It looks like it is pretty far out of date. Which tornadofx commits need to be ported?

SO Question today: http://stackoverflow.com/questions/42381874/cant-use-fontawesomefx-with-kotlin-and-tornadofx/42385796#42385796

@gtnarg It's not even the same control anymore. I'm unsure if I should maintain tornadofx-controls, or just port the remaining controls to TornadoFX and put that one to sleep. What do you think?

@edvin you have a pull request for the guide

@ron Thank you!

and I am changing the trayicon function:

@User uploaded a file: Untitled

Nice, that's better.

I make a PR