https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    02/26/2017, 11:19 AM
    @ron Should we do a release of FXLauncher or is it more stuff you'd like to add?
  • r

    ron

    02/26/2017, 11:19 AM
    there is more stuff I like to add but my desktop is dying.
  • r

    ron

    02/26/2017, 11:19 AM
    need to fix that first
  • e

    edvin

    02/26/2017, 11:20 AM
    Hehe, OK 🙂
  • e

    edvin

    02/26/2017, 11:20 AM
    Should we hold off on the release then?
  • r

    ron

    02/26/2017, 11:20 AM
    no I think there is so much new a release is good now
  • r

    ron

    02/26/2017, 11:20 AM
    gives me time to get that thing working again before I add the two options we talked about
  • c

    carlw

    02/26/2017, 11:30 AM
    @edvin can you wrap the function in an object and keep a reference to that for the unsubscribe?
  • e

    edvin

    02/26/2017, 11:31 AM
    @carlw That's exactly what I'm about to do 🙂 hehe.. Busy for a while, will commit a solution to this shortly.
  • c

    carlw

    02/26/2017, 11:54 AM
    @edvin are you verifying the references in jvisualvm?
  • e

    edvin

    02/26/2017, 11:55 AM
    @carlw What do you mean?
  • e

    edvin

    02/26/2017, 12:16 PM
    Ah, that was much better:
  • e

    edvin

    02/26/2017, 12:16 PM
  • e

    edvin

    02/26/2017, 12:21 PM
    The guide has been updated.
  • p

    permalmberg

    02/26/2017, 12:26 PM
    Nice 🙂
  • p

    permalmberg

    02/26/2017, 12:28 PM
    @edvin here's an idea: How about an optional callback interface, which, if it returns true, causes the unsubscribe to be triggered?
  • p

    permalmberg

    02/26/2017, 12:28 PM
    Then you could pass in an object instead of just a number that determines if/when to unsubscribe
  • e

    edvin

    02/26/2017, 12:29 PM
    That would be nice, but it would be an API break.
  • e

    edvin

    02/26/2017, 12:29 PM
    I have another idea which could be implemented without breaking the API...
  • e

    edvin

    02/26/2017, 12:29 PM
    The event could operate on an EventContext, so you can call 
    unsubscribe()
    directly on that from within the listener.
  • p

    permalmberg

    02/26/2017, 12:29 PM
    could be an overload? doesn't break the API..
  • p

    permalmberg

    02/26/2017, 12:30 PM
    that'll also work
  • e

    edvin

    02/26/2017, 12:31 PM
    Creating an 
    EventContext
    object.
  • e

    edvin

    02/26/2017, 12:33 PM
    What this would break however, is if somebody assigned an event to a variable, like I just did in that example.
  • p

    permalmberg

    02/26/2017, 12:38 PM
    why?
  • e

    edvin

    02/26/2017, 12:43 PM
    Because I defined 
    myListener
    like this: 
    val myListener: (MyEvent) -> Unit
  • e

    edvin

    02/26/2017, 12:43 PM
    It would now be 
    val myListener: EventContext.(MyEvent) -> Unit
  • p

    permalmberg

    02/26/2017, 12:44 PM
    ah
  • e

    edvin

    02/26/2017, 12:44 PM
    But it's worth it
  • e

    edvin

    02/26/2017, 1:57 PM
    Committed, and guide is updated yet again 🙂
1...916917918...2007Latest