Then you need to make the columns editable.

package test.view import javafx.scene.input.MouseEvent import tornadofx.* class data { var lastName by property <String>() fun lastNameProperty() = getProperty(data::lastName) var firstName by property<String>() fun firstNameProperty() = getProperty(data::firstName) override fun equals(other: Any?): Boolean { if(other is data){ if (lastName==other.lastName && firstName==other.firstName) return true } return false } override fun hashCode(): Int { return super.hashCode() } } class dataModel : ItemViewModel<data>() { val lastName = bind { item?.lastNameProperty() } val firstName = bind { item?.firstNameProperty() } } class MainView : View("Hello TornadoFX Application") { val list = mutableListOf<data>().observable() override val root = tableview<data>(list) { column("first name", data::firstName){isEditable=true} column("last name", data::lastName){isEditable=true} enableCellEditing() addEventFilter(MouseEvent.MOUSE_CLICKED) { event -> if (event.clickCount == 2 && event.target.isInsideTableRow() && selectionModel.isEmpty) { val transaction = data() items.add(transaction) edit(items.indexOf(transaction), columns.first()) } } } }

nope

I'll check this later when I am home

I must be missing something stupid

You need to call

makeEditable()

or else you haven't supplied an editor to your columns.

ok now it edits but it does not seem to store the changes

when I leave the column field its gone

@ron You need to override

onEditCommit

as well, but there seems to be multiple issues with this. Checking, will let you know how it goes.

no hurry

Try this:

@User uploaded a file: Untitled

It works, but doesn't enter edit mode for the first row if the table is empty. It works great when the second row is added.

Can you confirm that you see the same thing?

You have to submit the value by pressing enter in the textfield by the way

the version I just pasted you can edit the first row if the table was empty, but like I said it forgets the changes

but you do a lot more here 🙂

and you hav it working with

isInsideRow()

I need to do isInsideTableRow()

and I keep not getting the data in the cell once I leave the cell

@User uploaded a file:

@ron does the value save if you hit enter and then leave the cell?

@ron As I said, you need to hit enter. JavaFX will not call editCommit when you just loose focus on the editing cell.

hmmz I need to think about that UI wise

It might be possible to commit on focus lost...

But I'm not sure if you'd want to really. How would you cancel an edit?

Just escape cancels?

I find that users do not expect to have to hit enter to commit the value.

So they expect any change to be performed, as long as they didn't click Escape?

That does make sense.