https://kotlinlang.org logo
Channels
Powered by
#tornadofx
  • e

    edvin

    03/01/2017, 6:41 AM
    If you entered the wrong password you'd get a validation error just like the required error.
  • e

    edvin

    03/01/2017, 6:42 AM
    And get rid of the vbox :))
  • e

    edvin

    03/01/2017, 6:42 AM
    It looks like it possibly creates some padding for you now, so just set 
    paddingAll = 15
    or something inside the form.
  • e

    edvin

    03/01/2017, 6:44 AM
    I also think that the 
    val passwordEntered = SimpleStringProperty("")
    should be inside the 
    openInternalWindow
    builder, right now it is captured by the lambda and reused, so if you get the lock screen twice, it might contain the prior value you entered. And you don't need to add 
    ""
    to 
    SimpleStringProperty
    , it will be blank by default.
  • r

    ron

    03/01/2017, 6:45 AM
    validation is done in the repository as the password is not saved in clear text
  • e

    edvin

    03/01/2017, 6:45 AM
    @ron That's all fine. You could validate directly on the passwordfield and call out to the repository.
  • r

    ron

    03/01/2017, 6:46 AM
    the method isEqualToPassword encodes the passwordField.value and then does the comparison
  • e

    edvin

    03/01/2017, 6:46 AM
    passwordfield(passwordEntered).validator {if (controller.repository.isEqualToPassword(passwordEntered.value)) null else "Wrong!" }
  • e

    edvin

    03/01/2017, 6:48 AM
    (That would require a ViewModel though)
  • r

    ron

    03/01/2017, 6:51 AM
    a view model for one single string that is used in one place only?
  • r

    ron

    03/01/2017, 6:51 AM
    feels a bit like overkill to me
  • r

    ron

    03/01/2017, 6:52 AM
    btw if you want to do it with that validator it should be 
    if (controller.repository.isEqualToPassword(passwordEntered.value)) null else ValidationMessage("Wrong!", ValidationSeverity.Error) }
  • e

    edvin

    03/01/2017, 6:54 AM
    @ron You can return strings as well 🙂
  • r

    ron

    03/01/2017, 6:54 AM
    no, the ide did not want that
  • r

    ron

    03/01/2017, 6:54 AM
    gave an error
  • e

    edvin

    03/01/2017, 6:55 AM
    Oups, sorry. But there are shortcuts to creating ValidationMessage objects.
  • e

    edvin

    03/01/2017, 6:55 AM
    error("Wrong!")
  • e

    edvin

    03/01/2017, 6:55 AM
    info("Good")
  • e

    edvin

    03/01/2017, 6:55 AM
    warning("Weak password")
  • e

    edvin

    03/01/2017, 6:55 AM
    success("Perfect!")
  • e

    edvin

    03/01/2017, 6:55 AM
    Yeah, I agree it's a little overkill for this thing. Will look into that.
  • r

    ron

    03/01/2017, 8:53 AM
    @edvin cannot check right now, but the Ad Hoc Validation described in https://github.com/ronsmits/tornadofx-guide/blob/master/11.%20Editing%20Models%20and%20Validation.md might work here
  • e

    edvin

    03/01/2017, 9:57 AM
    @ron Haha, I just got exactly the same use case. Checking adhoc validation now, had completely forgotten about it.
  • e

    edvin

    03/01/2017, 10:04 AM
    That actually worked pretty well. Not much boiler plate, but we can for sure improve it further as well.
  • r

    ron

    03/01/2017, 10:05 AM
    Show me!😆
  • e

    edvin

    03/01/2017, 10:06 AM
  • e

    edvin

    03/01/2017, 10:07 AM
    @User uploaded a file:

    Validation triggered by clicking button with no value in input▾

  • e

    edvin

    03/01/2017, 10:07 AM
    We can improve this in multiple steps. First, lets create a addRequiredValidator to ValidationContext.
  • e

    edvin

    03/01/2017, 10:08 AM
    No, actually, let's not do that.
  • e

    edvin

    03/01/2017, 10:08 AM
    I have a better idea.
1...930931932...2007Latest