Yes 🙂 I'll sleep well knowing that the vbox will die.

I know 🛌

@edvin the dialog is nice, but for some parts (like the lockscreen) I will use the internalWindow

Absolutely, it makes it easier to hide the background as well.

We could make an internalDialog of course.

We could also give dialog it's own validationContext

Grr.. but that might be confusing.

I'd rather give Form it's own validationContext actually.

But I keep thinking that people will use forms with their own viewmodel and then try to commit the form's context.

Nah, let's leave it for now.

@ron I found a slightly better way

@User uploaded a file: Untitled

Use a stock ViewModel and bind some properties to it. Gives you best of both worlds with minimal boilerplate.

This should work just fine and no need to have form with its own validation context

Agreed.

Updated the guide

yup looks good

we had a talk yesterday about behaviour in the tableview with inline editing. I kinda missed the result of that talk

I didn't have time to deal with it just then, and I see that the problem domain is even larger than we discussed. People might have different preferences as to what should happen on focus lost etc. I didn't even find a good hook to implement it without overriding the editor, so I need to think about that some more.

Well for my usecase I have decided to just a have an "add" button that opens an internal window

basically an "add" and an "edit" button

internalWindow always opens centered on the stage, is there a way to override that?

for example centered over the row? or the table?

@ron No, you'd have to move that yourself by giving it the node it should center over and doing it manually.

@nimakro Should we seek to reduce boilerplate even more for the dialog builder? Any suggestions?

@edvin I think I will first try the dialog builder for my use case and report back if I find anything to complicated.... Thanks again for the work

@nimakro Great 🙂 It's a different approach than the default JavaFX dialog, but this feels more straight forward to me.

Oky will see what I think when I use it 😉

It's a lot less code