@carlw There 🙂

@ron Yeah, I should have done something else I guess. I just implemented an IRC client that updates the list of nodes representing the users in a channel using this technique. Really cool 🙂

@carlw The solution was simply to relay the MOUSE_EXITED event to the button as well.

testing

@edvin much better solution. thanks. do you mind if i blog a java version of this? it's a shame to have to do that b/c the extension function is so cool. i was able to open up another file and just add your code in without recompiling the source class.

@carlw Please do 🙂 But remember to mention that this solution doesn't take changing the parent into account, and the parent must be available when you call the function. Those things could quite easily be fixed, but I don't know if it's needed.

it's needed in my case, but that's trivial

Great 🙂 Post the blog link here when it's done? 🙂

will do. is the solution going to be in a future tornadofx release?

you're on windows, right?

@edvin when the function is reenabled, how would you call removeEventFilter? Is there a reference kept somewhere?

@carlw In the simple version I created there is no way to remove the filter since it's not stored anywhere. This should be addressed in the parentProperty onchange handler I think.

ok...i think my java solution is going to have handles to everything

@carlw We could fix it up and add it to TornadoFX for sure 🙂

@ron I just got an idea about the DslMarker annotation.. Maybe we could find a way to do two releases - one with and one without the markers? That would be a gentle way to introduce them...

I liked your first idea better let's investigate where we need it and introduce it in 2.0

@ron If we need to add wrapper classes to every class the builder works on, this could be introduced as an optional dependency perhaps. Will look into it.

We also need to look at exactly how it behaves

@edvin this is to prevent someone from adding a stackpane to a label?

@carlw It solves two big issues. It prevents you from calling

alignment = x

on a

label

inside an

hbox

, because the

alignment

property of the

hbox

will no longer

bleed

into the scope of the label builder. The second big win with this is that you can hit ctrl-space and get an accurate list of available functions and properties for the current node inside the builder hierarchy. That's a huge step forward because new features can be discovered very easily.

@edvin too bad they don't have extension classes to go with extension functions

@carlw Yeah, just the ability to add annotations to existing classes would actually solve this for us.

@edvin they should come up with something like a DSLProvider which would be a factory of related DSL objects

Maybe we could hack it with javaassist or something.

@carlw Yeah, something like that could work.

@edvin that's what hibernate does...it seems like Guice or Spring which have the -at-Inject annotation but also a method technique if the annotation isn't possible

There is one other option for us however. That would be to solve this with the TornadoFX plugin. Augmenting the content assist list on the fly. I have no idea about how or if it's even possible, but I suspect it is.

This is all about IDE support, and really has nothing to do with runtime, so it's a bit different.

right. what type of error would you get if you did label { stackpane{} } ?

They must have already solved this by letting the plugin access the dsl markers, so there might be something we can.