night

@ron i'm putting it to 1.7.0. if there's a pull request, my changes will go into a general javafx project. i don't expect them to have a local build of tornadofx

night

If anyone's interested in the Todo app, I've updated my project to Kotlin 1.1, JVM 1.8, and TornadoFX 1.7.0. I think what I have meets the functional requirements, but it still looks like more like a traditional JavaFX program than a TornadoFX one. The main piece that's missing is the Type Safe Builders. I'll be able to work on that a little tomorrow. If you work on this, please get familiar with a regression test involving filters, additions, select all, and viewable items. Notice that the items drop off if the filtering criteria is set and items are changed via the select all or the individual check boxes. I've tested this operator-for-operation against another Java app in the project:todomvcfx.mvvmfx.MvvmfxApp. I'm sure there's a lot to trim, but I think it's important to keep the author's intent for a fair comparison. If we can throw everything in a single listview {}, great, but let's not shed requirements.

For the newcomers: A GitHub project lestard/todomvcFX put out a calling last year for reference applications using different JavaFX frameworks. A few people made some contributions and reviews, but everyone got busy and the TornadoFX version went to sleep for a while.

Great Carl! I would like to investigate how we'd write this todo app if we didn't look at any existing code. There might be more TornadoFX shortcuts we can utilize. I'll have a look as soon as I get my head above water again.

There are a lot of tests already in the Todo project.

@edvin is Boss already usable?

@ron No, I just did the fun parts. I'd really love to start working on it again, but now it looks like I'll be doing the Todo app first. That's a healthy exercise, the last time around it spawned a lot of good features.

Real life use cases usually are

I am re writing the last Java parts to kotlin K

@edvin do you want to clone your own project to get a fresh start or did you mean not looking at manuel's existing code?

@carlw I'd like to only look at the running app, not look at any existing code.

why don't you clone a fresh copy and we'll write PR's against your project?

Clone a fresh copy of what? Did I commit a version of this? Can't remember 🙂

Of Manuel's project

Which one is Manuel's project? Is that a plain JavaFX version?

He has several versions: MVVM, Redux, Flux

My repo adds a tornadofx. This is the original project https://github.com/lestard/todomvcFX

the projects are stored under todomvcFX/examples

That's what I want to avoid. Any kind of bias as to how this is implemented. I just want to see what it does and try to think "TornadoFX" 🙂

If everything goes well I'll merge it into the original project.

Can't you just run it? I haven't even opened any of the files in the reduxfx project for example

I will 🙂

Alright. Let me know if I can help with it

Thank you Carl 🙂

I have a pure kotlin question

I had intellij convert a java class to kotlin

this method

private Cipher getCipher() throws NoSuchAlgorithmException, NoSuchProviderException, NoSuchPaddingException {
        return Cipher.getInstance("AES/CBC/PKCS5Padding", "SunJCE");
    }