kotlinlang #tornadofx

private val cipher: Cipher
        @Throws(NoSuchAlgorithmException::class, NoSuchProviderException::class, NoSuchPaddingException::class)
        get() = Cipher.getInstance("AES/CBC/PKCS5Padding", "SunJCE")

ron

03/08/2017, 2:43 PM

in the java code there was a lot of

Cipher cipher = getCipher()

ron

03/08/2017, 2:43 PM

I expected that I would not need that anymore the code

val cipher = cipher

looks weird 🙂

ron

03/08/2017, 2:44 PM

but not doing that means the cipher is not initialized

ron

03/08/2017, 2:44 PM

keepassFX.utils.EncryptionException: java.lang.IllegalStateException: Cipher not initialized

edvin

03/08/2017, 2:53 PM

Interesting. I was sure this was a bug to begin with: https://github.com/edvin/tornadofx/issues/266#issuecomment-285060123

edvin

03/08/2017, 3:52 PM

@nimakro You can actually just do

addClass

with the type safe classes, even for pseudoclasses. It will automatically detect pseudo classes and do the right thing. @Ruckus do you think we should add a

addPseudoClass(cssRule)

to avoid any confusion?

nimakro

03/08/2017, 3:53 PM

ah I see

edvin

03/08/2017, 3:53 PM

@nimakro How is

hasItem

defined in your stylesheet?

nimakro

03/08/2017, 3:57 PM

val hasItem by csspseudoclass()

edvin

03/08/2017, 3:59 PM

@nimakro Does it work when you change

addPseudoClass("hasItem")

addClass(hasItem)

nimakro

03/08/2017, 4:01 PM

@edvin Yes, if I call it with

addClass(ApplicationStyle.hasItem)

it works.

nimakro

03/08/2017, 4:02 PM

So it could be that there is a bug with the

addPseudoClass(String)

Version?

edvin

03/08/2017, 4:12 PM

@nimakro I don't think so actually. Looking at the code it's pretty simple:

edvin

03/08/2017, 4:13 PM

@User uploaded a file: Untitled

-.kt

edvin

03/08/2017, 4:31 PM

@nimakro That's right :)) Sorry, was doing math homework with my daughter 🙂

😉 1

Ruckus

03/08/2017, 5:09 PM

@nimakro You can use

Copy code

val hasItem by csspseudoclass(snakeCase = false)

to make the name "hasItem"

Ruckus

03/08/2017, 5:10 PM

You can also use

addPseudoClass(ApplicationStyle.hasItem.name)

to make sure you use the generated name (and be safe against refactoring)

Ruckus

03/08/2017, 5:11 PM

@edvin That's probably not a bad idea:

Ruckus

03/08/2017, 5:14 PM

What would it do if you pass in a non pseudo-class rule?

edvin

03/08/2017, 5:19 PM

@Ruckus That's a good point. Maybe it's better to not add it. I'll add documentation (🎉) to the addClass function instead!

👍 2

nimakro

03/08/2017, 5:25 PM

@Ruckus thanks for the info, but I think I will stick with

addClass

since it can handle both 😉

👍 1

Ruckus

03/08/2017, 5:27 PM

Sounds good to me 🙂

edvin

03/08/2017, 5:27 PM

Committed docs 🙂

👍 3

ron

03/08/2017, 10:34 PM

oh man that elvis operator can be so cool:

val browserKey = repository.getKeyFromBrowser(browserId) ?: return BAD_REQUEST

👍 3

Ruckus

03/08/2017, 11:31 PM

New question: http://stackoverflow.com/questions/42682467/modal-stage-isresizable

edvin

03/09/2017, 7:22 AM

@ron You can even do

getMightBeNull() ?: throw Exception("Need a value")

edvin

03/09/2017, 7:23 AM

@ron What do you think of my last comment on this FXLauncher issue? https://github.com/edvin/fxldemo-gradle/issues/6

edvin

03/09/2017, 7:26 AM

@Ruckus About the SO question: I think you're right, this is probably the best/only way to do it. But we could probably add resizable as a parameter to openModal 🙂

ron

03/09/2017, 7:49 AM

@edvin that last comment about closing the update dialog maybe he could use the headless launcher?