getting some test failures on Guice setup now

well check it in 🙂 👏

For your KeepassRepositoryTest, do you mean to have an empty Guice Module? I'm getting a BridgeService error b/c it doesn't look like the implementation is linked up anywhere

hmmz its supposed to be linked up, I will check it tonight(in the office in a boring meeting)

ok. i think you need to either provide a mocked object to Guice or wire up a JMock/Easy mock implementation

are you on the master branch or the develop branch?

you should be on the develop branch 🙂

i'm on develop

@Ruckus I'm converting some .css to the typesafe builders. What's the correct syntax for backgroundColor = none?

@carlw Is "none" somethig else than "transparent"?

I'm not sure...here's the CSS I'm converting

.content_box .button { -fx-background-color: none; }

none is not valid CSS

@carlw Ron is right.

none

is not a valid input for

-fx-background-color

. (It's only an acceptable value for border style and tab animations). I'll do some tests to see what it actually comes out to.

@Ruckus don't spend too much time on it. I pulled this from Manuel's TodoMVC css and fxml. I don't think all the styles are being used so this might be dead code

I've seen people try to use it many times before, so it's a question that will probably come up again. It will be good to know the correct value to use to get the same result.

For now, if you want to force the same CSS, you can use

unsafe("-fx-background-color", raw("none"))

maybe it's ought to have been -fx-background: none as in -fx-background-image: none?

Interestingly, setting

-fx-background-color

to

none

or

null

works (despite not being allowed according to the docs), but setting

-fx-background

to

none

or

null

triggers a warning.

It looks like if you set the background color to

none

the the resulting object has

null

as its background value, which is rendered the same as setting it to

transparent

. When it's set to

transparent

, however, it does create a background object, even though it renders the same.

So setting

backgroundColor += Color.TRANSPARENT

is the way to go to get the same results. (

backgroundColor += c("transparent")

works as well)

(Technically,

-fx-background

isn't an actual property, though JavaFX will still accept many values for it.)

thx. i'll give Color.TRANSPARENT a shot later today

Guys, the Wiki page that describes CSS is different from the Guide. We need to figure out if the guide covers everything from the Wiki and then remove the Wiki page and link to the CSS section in the guide.

@edvin Here's what I noticed about the guide with a quick check: - Explanation for dimensions seems to ba lacking - Explanation for

box

helper function seems to be lacking - No explanation of functions like

removeClass

,

toggleClass

,

hasClass

, or

select

on `Node`s - No explanation of more complex selectors (using infix functions and whatnot) - No explanation of String literal selectors - No reference to what classes and properties are available by default

I don't think all of these need to be addressed (at least not in the main page), I just included whatever came to mind.

@Ruckus Thank you for the summary. I will do what I can, might need to ask you a few questions along the way.

Sounds good. I have quite a few meetings today, so my response time may be dismal.

Also, that list isn't exhaustive. Just a quick pass.

@Ruckus I won't have time to even start today I'm afraid. Saving the list in an issue so we have it for later, probably next week.