@edvin Sounds good to me

Created it now 🙂

@ron Are we ready for FXLauncher release?

@ron Maybe we should save scp to the next version? This one is pretty feature packed already.

We are ready

Did you merge all the pro's?

@ron I think so. I`ll start running some tests tomorrow, I haven`t tried half of it yet.

@ron You have a PR with merge conflicts: https://github.com/edvin/fxlauncher/pull/58 - It might be because I merged the HeadlessLauncher.

@ron I could try to merge it manually.

@ron And I'll add that option to the gradle plugin right now 🙂

So you broke itsimple smile

Hmm.. This option is just for command line usage right, not in manifest?

Just command line

Yes, I broke it. Sorry 🙂 I thought you had already merged it you see.

If it's too hard to merge I can add it later it's not that much code

It should be fine, trying now.

@ron That wasn't completely trivial. I think this should go into AbstractLauncher now. Could you take a look?

I will look at it

@Ruckus Have you seen a stylesheets error coming from Scenic View like this? java.lang.NullPointerException at org.scenicview.extensions.cssfx.module.impl.CSSFXMonitor$StyleSheetChangeListener.lambda$isAManagedSourceURI$39(CSSFXMonitor.java:449) at java.util.stream.MatchOps$1MatchSink.accept(MatchOps.java:90) at java.util.LinkedList$LLSpliterator.tryAdvance(LinkedList.java:1249)

it seems like I'm in an infinite loop, getting a lot of NPE popups. The app runs fine otherwise

@ron Sorry for messing up again, that's the second PR I've botched 🎅

@carlw I have not, but I've rarely used Scenic View.

@Ruckus ok. i also tried commenting out the reload on focus statement in the init() method.

@Ruckus I'm going to set scenic view aside for now. Maybe i'll have time to look at it later. This doesn't happen if I pull Style::class out of the App() constructor

@carlw Interesting

I remember I had some issues with ScenicView as well, but those were caused by Kotlin creating some invalid class names when using crossinline on parameters. Probably not the same here though.

it looked like the polling of styles from Scenic View was throwing an NPE and consequently displaying an Alert. I couldn't close them fast enough and had to abort.

@Ruckus If you do have scenic view, I would be curious to see if you get the same results on one of your tried-and-true programs.

@carlw I can't replicate it. I've tried with a few of my programs and they seem to work fine.

@Ruckus Your app looks like this? class TornadoFXApp : App(MainView::class, Styles::class) { init { reloadStylesheetsOnFocus() } }