toggleCompleted puts all of them in completed state?

No, it toggles completed for the currently visible items, ie. the items that satisfies the current predicate.

It finds all visible items that differ from the passed in state and switches them to the passed in state.

Writing it more imperative is really not easier to understand and you're more likely to have a bug in there.

By the way, that predicate thing is all the code that deals with filtering in the TornadoFX version of the Todo app. The others have long lines of binding swearing like this:

@User uploaded a file: Untitled

By utilizing the SortedFilteredList, we don't need to deal with any of that. Also, the others modifies the items list for the ListView on filter, we keep the same list throughout.

That java code just looks bad compared to the predicate stuff you posted before 😉

Just trying to understand what it does is hard. And that's about half the code involved.

And that's what drawn me to tornadofx or kotlin in general in most cases it jut looks beautiful...

@edvin - I agree that the functions are better - you mentioned that you never use events?

@gtnarg No, I never assign nodes to variables in the View 🙂

I like events.

Assigning nodes to variables feels like a code smell to me. Not sure if I'm correct though.

@edvin - like most rules - “it depends” 🙂

Yes. I find that almost in every instance when I think I need to do that, I can just create a property for the value and mediate though it instead. That feels much cleaner to me.

Next time I run into it I will get your feedback to see how I could alternatively do it..

Let's say you want to know about the checked state of a checkbox. The semantics of checking the checked state of a ui control compared to checking the value of a properly named BooleanProperty are not as clear.

@gtnarg Please do!

like this

@User uploaded a file: Untitled

(You most likely don't really care about the state of the check box, you care about a certain state in your app, which is better expressed through a property)

@ron That's a good example. Many might expose the checkbox instead.

Now I see where you are going - it’s similar to the benefits of mvvm - you can test the model separate from the view - and the only logic in the view is actual view logic that doesn’t work anywhere else

@gtnarg Absolutely 🙂

yes that is why the controllers and in the case of keepass the

KeepassRepository

is so important they do all the real lifting

the views and fragments constantly call out to them

I would love to test the controller too, but its quite connected to tornadofx have not really looked into it yet

I just noticed that the other todo apps take care to write

1 item left

and

2 items left

. I solved it like this: