I have never seen the need for it. I do pretty complex stuff without every feeling like Rx would help, but that might be because I don't fully understand it, or see the added value yet.

same here

This is a sample app I wrote yesterday. Looking at the code it looks dead simple, but some advanced stuff is still happening there: https://github.com/edvin/todomvc

Lunch time here 🙂

Cool, checking it out now!

Whops. Actually the name property i used was the parameter of public interface KCallable<out R> : KAnnotatedElement, and I can’t access the name property if Building

@edvin ordered https://www.amazon.co.uk/dp/B01D41O5P2?ref_=ams_ad_dp_asin_3

colleague here in the office has it and it works quite nice

@ron looks nice. do you miss the num keypad?

no never use it

in the game I so every now and then play the numkey+ and numey- are used but I can fake that

lunch time

@borboss I haven't looked at that in awhile. I might need to see if there is opportunity to clean it up.

Is anyone having trouble with a unit test "composedFormFXML"? It is based on a .fxml file that includes other .fxml files. I'm going to write a PR since it was failing on 2 different machines for me this morning

Wow! Hello Thomas! Very cool book 😉 Actually I read the reactive domain modelling book and wanted to write my own version of kotlin + tornado + rx sample 😉

@borboss that would be awesome, I'm glad you like it. I'd like to see more examples because I tend to make mine have complex business requirements. So definitely feel free to share what you build

@borboss @edvin what do you think would help the SalesPerson class look better? More code separation? I think a lot of this can be cleaned up with some of the new features added in TornadoFX... like TableView dirty state tracking.

@edvin I got the fx:include unit test working by falling back on an -at-FXML annotation. In the current FXML, there is a View with two child Views. All 3 views base their roots on an FXML file reference. This is the existing class of one of the child Views which is throwing the LoadException class ComposedFormSearchController : View() { override val root : HBox by fxml("/torandofx/test/ComposedFormSearch.fxml") val tfSearch : TextField by fxid() fun search() { println("search=" + tfSearch.text) } } This is working for me class ComposedFormSearchController : Controller() { @FXML var tfSearch : TextField? = null fun search() { println("search=" + tfSearch?.text) } }

@thomasnield I will look at it and probably ask you some questions later 🙂 I have a couple of ideas!

@carlw Hm... all tests pass for me.

I remember we added some tests for functionality we later rolled back though.

But everything in head passes when I run

mvn test

.

@edvin To keep code clean I just added the property - val buildingName = building.buildingName and map column(”BUILDING", Biulding::buildingName) A bit ugly, but ok, I suppose 😉

@borboss You could also use the syntax I showed earlier, or

column<Room, String>("Building", { SimpleStringProperty(it.value.building.name) })

These things are optimized for using JavaFX Properties, so there are some extra hoops for POJOs.

@edvin was there something changed in the eventbus? https://github.com/edvin/tornadofx/issues/280

@ron Yes, sorry about that. I've described the change on the ticked. Good call to create it instead of just asking here, so others can see it as well.

he its not my ticket, I just happened to see it

Haha, I didn't even notice 🙂 Going on auto pilot here.

Got an electrician and two glass/wall/door people working in my office right now, so I'm a bit distracted.