https://kotlinlang.org logo
Title
m

Marcello Galhardo

04/07/2023, 7:05 PM
But you should be able to test by changing the device date & hour to about 15 minutes before the session bookmarked.
j

John O'Reilly

04/07/2023, 7:06 PM
cool, will try that
m

Marcello Galhardo

04/07/2023, 7:06 PM
Remember to turn on the flag!
j

John O'Reilly

04/07/2023, 7:06 PM
yeah, have that enabled
be great if you could do some sanity testing with version in play store too before I promote
m

Marcello Galhardo

04/07/2023, 7:06 PM
Let me know how it goes.
I'm preparing dinner now but afterwards I can fix any bug you find. (:
Yes, also I think there was a merge conflict right? Would be nice to check if everything is working at runtime.
Notifications doesn't seem to be working for me in the internal version. What about you @John O'Reilly?
j

John O'Reilly

04/07/2023, 8:29 PM
Only got chance to test just now and doesn't seem to be
does it work there locally with code from
main
?
m

Marcello Galhardo

04/07/2023, 8:29 PM
It was working previously for me, yes. Not sure what happened.
j

John O'Reilly

04/07/2023, 8:30 PM
was more wondering if maybe something changed after other PRs were merged....
could it be time zone issue I wonder
m

Marcello Galhardo

04/07/2023, 9:13 PM
I'll have a look into that. 🤔
y

yschimke

04/07/2023, 10:06 PM
This should probably be using the conference timezone, and adjusting.
private fun createIntervalRange(): ClosedRange<LocalDateTime> {
        val now = dateService.now()
        val timeZone = TimeZone.currentSystemDefault()
        val future = (now.toInstant(timeZone) + INTERVAL).toLocalDateTime(timeZone)
        return now..future
    }
j

John O'Reilly

04/08/2023, 7:38 AM
I had tried changing my time here to match time zone but still didn't seem to trigger notification
@Marcello Galhardo suspecting following was cause of issues I was seeing.....checking again now https://kotlinlang.slack.com/archives/C051P2HUVKP/p1680940894361469
I'm seeing SessionNotificationWorker startWorkRequest being invoked.....but not doWork for some reason
m

Marcello Galhardo

04/08/2023, 12:12 PM
Nice, thank you for this info. Will help debug later!